Bug 109235

Summary: [Chromium] Get rid of WebAnimationController
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: James Robinson <jamesr>
Severity: Normal CC: benjamin, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing none

Description Benjamin Poulain 2013-02-07 15:00:12 PST
The animation and transition testing has been moved to Internals in r142171 && r141849.

Chromium WebAnimationController should be useless now. It is used in webkit/glue/dom_operations.cc.

It would be nice if you could clean that up and remove the class.
Comment 1 James Robinson 2013-02-08 19:39:41 PST
Ooh, I love deleting code!
Comment 2 James Robinson 2013-02-08 20:17:51 PST
Created attachment 187401 [details]
Comment 3 James Robinson 2013-02-08 20:18:10 PST
https://codereview.chromium.org/12209082/ will have to land + roll in first.
Comment 4 Benjamin Poulain 2013-02-08 20:22:46 PST
Comment on attachment 187401 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=187401&action=review


> Tools/ChangeLog:11
> +        * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
> +        (WebTestRunner::TestRunner::TestRunner):
> +        * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
> +        (TestRunner):

I am sorry, I apparently forgot those when cleaning DRT :(
Comment 5 James Robinson 2013-02-11 22:02:03 PST
Created attachment 187772 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-02-11 22:48:19 PST
Comment on attachment 187772 [details]
Patch for landing

Clearing flags on attachment: 187772

Committed r142582: <http://trac.webkit.org/changeset/142582>
Comment 7 WebKit Review Bot 2013-02-11 22:48:22 PST
All reviewed patches have been landed.  Closing bug.