Bug 109183

Summary: Web Inspector: [Regression] breakpoint condition not editable
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andrey Lushnikov 2013-02-07 06:01:44 PST 
It's impossible to set up a selection inside breakpoint condition editbox.
Comment 1 Andrey Lushnikov 2013-02-07 06:31:56 PST 
Created attachment 187089 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-02-07 06:50:07 PST 
Comment on attachment 187089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187089&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2096
> +        for(var i = 0; i < this._decorationElements; ++i) {

Traversing all decorations element seems not quite efficient.
You can tyr using the fact that all decorations are stored in the div with "webkit-line-decorations" class.
Comment 3 Andrey Lushnikov 2013-02-07 06:55:36 PST 
Created attachment 187097 [details]
Patch
Comment 4 Andrey Lushnikov 2013-02-07 07:17:45 PST 
Created attachment 187103 [details]
Patch
Comment 5 WebKit Review Bot 2013-02-07 09:19:02 PST 
Comment on attachment 187103 [details]
Patch

Clearing flags on attachment: 187103

Committed r142138: <http://trac.webkit.org/changeset/142138>
Comment 6 WebKit Review Bot 2013-02-07 09:19:06 PST 
All reviewed patches have been landed.  Closing bug.