Summary: | Conversion from localized numbers to HTML numbers should accept not only localized numbers but also HTML numbers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | haraken, morrita, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kent Tamura
2013-02-07 02:37:10 PST
Created attachment 187030 [details]
Patch
Comment on attachment 187030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187030&action=review > Source/WebCore/platform/text/PlatformLocale.cpp:309 > // Input is broken. Returning an invalid number string. Update this comment. > LayoutTests/fast/forms/number/number-l10n-input.html:20 > +document.execCommand('InsertText', false, '1'); > +shouldBeEqualToString('arabicInput.value', '1'); You might want to test all of '1', '1.23' and '1,23' for each input. Created attachment 187037 [details]
Patch 2
Comment on attachment 187037 [details]
Patch 2
Looks good.
Comment on attachment 187037 [details]
Patch 2
Thanks!
Comment on attachment 187037 [details] Patch 2 Clearing flags on attachment: 187037 Committed r142122: <http://trac.webkit.org/changeset/142122> All reviewed patches have been landed. Closing bug. |