Bug 109158

Summary: REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keishi Hattori 2013-02-07 01:39:59 PST
The triangles are pointing the wrong direction.
Comment 1 Keishi Hattori 2013-02-11 17:56:50 PST
Created attachment 187738 [details]
Patch
Comment 2 Kent Tamura 2013-02-11 18:14:11 PST
Comment on attachment 187738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187738&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.css:150
> +.rtl .year-month-button-right .year-month-button,
>  .year-month-button-left .year-month-button {
> -    margin-right: 4px;
> +    margin: 0 4px 0 0;
>  }
>  
> -.year-month-button-right {
> -    display: inline-block;
> +.rtl .year-month-button-left .year-month-button,
> +.year-month-button-right .year-month-button {
> +    margin: 0 0 0 4px;

Does -webkit-margin-end: 4px;  work?

> Source/WebCore/Resources/pagepopups/calendarPicker.css:281
>  .today-clear-area .today-button {
> -    margin-right: 8px;
> +    margin: 0 8px 0 0;
> +}
> +
> +.rtl .today-clear-area .today-button {
> +    margin: 0 0 0 8px;

Ditto.
Comment 3 Keishi Hattori 2013-02-11 18:39:14 PST
Created attachment 187749 [details]
Patch
Comment 4 Kent Tamura 2013-02-11 18:41:17 PST
Comment on attachment 187749 [details]
Patch

ok
Comment 5 WebKit Review Bot 2013-02-11 20:26:33 PST
Comment on attachment 187749 [details]
Patch

Clearing flags on attachment: 187749

Committed r142572: <http://trac.webkit.org/changeset/142572>
Comment 6 WebKit Review Bot 2013-02-11 20:26:36 PST
All reviewed patches have been landed.  Closing bug.