Summary: | Drop ExceptionCode from IDB's directionToString and modeToString. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike West <mkwst> | ||||||
Component: | WebCore Misc. | Assignee: | Mike West <mkwst> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alecflett, dgrogan, jochen, jsbell, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 108180 | ||||||||
Attachments: |
|
Description
Mike West
2013-02-07 00:10:28 PST
Created attachment 187010 [details]
Patch
Jochen, perhaps you can take a look at this patch? Joshua says it's the right thing to do, so I hope the details are trivially reviewable. :) It doesn't (yet) apply; I'll upload it again for the bots once https://bugs.webkit.org/show_bug.cgi?id=109044 lands. Comment on attachment 187010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187010&action=review > Source/WebCore/ChangeLog:9 > + make use of the ExceptionCode they accept. This patch drops the unused Nitpicking the description: the methods *did* use it, but all callsites ignored the result other than asserting because these methods are now only used with pre-validated data. > Source/WebCore/Modules/indexeddb/IDBCursor.cpp:-329 > - ec = TypeError; Please add ASSERT_NOT_REACHED() here. > Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:-365 > - ec = TypeError; Please add ASSERT_NOT_REACHED() here. (In reply to comment #2) > Jochen, perhaps you can take a look at this patch? Joshua says it's the right thing to do, so I hope the details are trivially reviewable. :) I'm Joshua and I approve this patch (with those ASSERT_NOT_REACHED additions). Thanks, Jochen, and thanks Mike for putting it together! Created attachment 187296 [details]
Patch
This should address Joshua's comments. Jochen, if I haven't exhausted your patience yet today, would you mind taking a look at this patch as well? Comment on attachment 187296 [details]
Patch
ok
Comment on attachment 187296 [details] Patch Clearing flags on attachment: 187296 Committed r142356: <http://trac.webkit.org/changeset/142356> All reviewed patches have been landed. Closing bug. |