Summary: | Web Inspector: [Resources] Prefactorings in DataGrid and CookieTable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eugene Klyuchnikov <eustas> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Eugene Klyuchnikov <eustas> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 109140 | ||||||||
Attachments: |
|
Description
Eugene Klyuchnikov
2013-02-06 23:45:33 PST
Created attachment 187005 [details]
Patch
Comment on attachment 187005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review > Source/WebCore/inspector/front-end/CookieParser.js:360 > + PageAgent.deleteCookie(cookie.name(), (cookie.secure() ? "https://" : "http://") + cookie.domain() + cookie.path()); cookie.port() ? (In reply to comment #2) > (From update of attachment 187005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review > > > Source/WebCore/inspector/front-end/CookieParser.js:360 > > + PageAgent.deleteCookie(cookie.name(), (cookie.secure() ? "https://" : "http://") + cookie.domain() + cookie.path()); > > cookie.port() ? No. Lease refer https://code.google.com/p/browsersec/wiki/Part2#Same-origin_policy_for_cookies Comment on attachment 187005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review looks good with a nit. > Source/WebCore/inspector/front-end/CookieParser.js:358 > +WebInspector.Cookie.deleteCookie = function(cookie) just declare it as "delete" on the WebInspector.Cookie.prototype. Also please add an optional callback. Comment on attachment 187005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review >> Source/WebCore/inspector/front-end/CookieParser.js:358 >> +WebInspector.Cookie.deleteCookie = function(cookie) > > just declare it as "delete" on the WebInspector.Cookie.prototype. Also please add an optional callback. Done Created attachment 187267 [details]
Patch
Comment on attachment 187267 [details] Patch Clearing flags on attachment: 187267 Committed r142441: <http://trac.webkit.org/changeset/142441> |