Bug 109141

Summary:

Web Inspector: [Resources] Prefactorings in DataGrid and CookieTable

Product:

WebKit

Reporter:

Eugene Klyuchnikov <eustas>

Component:

Web Inspector (Deprecated)

Assignee:

Eugene Klyuchnikov <eustas>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

109140

Attachments:

Description	Flags
Patch	pfeldman: review+
Patch	none

Eugene Klyuchnikov

Reported 2013-02-06 23:45:33 PST

1) Make deleteCookie method static and move to WebInspector.Cookie 2) Replace resfreshCallback getter/setter in DataGrid with constructor parameter

Attachments
Patch (7.59 KB, patch) 2013-02-07 00:27 PST, Eugene Klyuchnikov	pfeldman: review+	Details Formatted Diff Diff
Patch (7.61 KB, patch) 2013-02-08 01:46 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eugene Klyuchnikov

Comment 1 2013-02-07 00:27:42 PST

Created attachment 187005 [details] Patch

Andrey Adaikin

Comment 2 2013-02-07 05:50:35 PST

Comment on attachment 187005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review > Source/WebCore/inspector/front-end/CookieParser.js:360 > + PageAgent.deleteCookie(cookie.name(), (cookie.secure() ? "https://" : "http://") + cookie.domain() + cookie.path()); cookie.port() ?

Eugene Klyuchnikov

Comment 3 2013-02-07 21:07:20 PST

(In reply to comment #2) > (From update of attachment 187005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review > > > Source/WebCore/inspector/front-end/CookieParser.js:360 > > + PageAgent.deleteCookie(cookie.name(), (cookie.secure() ? "https://" : "http://") + cookie.domain() + cookie.path()); > > cookie.port() ? No. Lease refer https://code.google.com/p/browsersec/wiki/Part2#Same-origin_policy_for_cookies

Pavel Feldman

Comment 4 2013-02-07 23:46:31 PST

Comment on attachment 187005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review looks good with a nit. > Source/WebCore/inspector/front-end/CookieParser.js:358 > +WebInspector.Cookie.deleteCookie = function(cookie) just declare it as "delete" on the WebInspector.Cookie.prototype. Also please add an optional callback.

Eugene Klyuchnikov

Comment 5 2013-02-08 01:45:12 PST

Comment on attachment 187005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review >> Source/WebCore/inspector/front-end/CookieParser.js:358 >> +WebInspector.Cookie.deleteCookie = function(cookie) > > just declare it as "delete" on the WebInspector.Cookie.prototype. Also please add an optional callback. Done

Eugene Klyuchnikov

Comment 6 2013-02-08 01:46:57 PST

Created attachment 187267 [details] Patch

WebKit Review Bot

Comment 7 2013-02-11 02:13:24 PST

Comment on attachment 187267 [details] Patch Clearing flags on attachment: 187267 Committed r142441: <http://trac.webkit.org/changeset/142441>

Note You need to log in before you can comment on or make changes to this bug.