Summary: | webdatabase: Introduce SQLTransactionBackend and SQLTransactionBackendSync. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
Component: | WebCore Misc. | Assignee: | Mark Lam <mark.lam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, beidson, buildbot, gtk-ews, gyuyoung.kim, levin+threading, michaeln, rakuco, rniwa, sam, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 104750 | ||||||||
Attachments: |
|
Description
Mark Lam
2013-02-06 17:01:05 PST
Created attachment 186979 [details]
the patch.
Comment on attachment 186979 [details] the patch. Attachment 186979 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16416026 Attachment 186979 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/webdatabase/Database.cpp', u'Source/WebCore/Modules/webdatabase/Database.h', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.h', u'Source/WebCore/Modules/webdatabase/DatabaseTask.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTask.h', u'Source/WebCore/Modules/webdatabase/SQLTransaction.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransaction.h', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.h', u'Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.h', u'Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionSync.h', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h:67: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp:98: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp:160: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp:172: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp:215: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:40: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:42: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:267: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:288: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:358: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:370: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:383: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:502: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:579: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp:617: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 18 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 186979 [details] the patch. Attachment 186979 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16404036 Comment on attachment 186979 [details] the patch. Attachment 186979 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16417047 Comment on attachment 186979 [details]
the patch.
The patch mechanism is not ordered. Hence, my renaming a file (e.g. SQLTransaction.h to SQLTransactionBackend.h), and then creating a new one (E.G. SQLTransaction.h) with the same old name can result in badness. Reworking the patch to just add the file with the different name (e.g. SQLTransactionBackend.h) as a new file.
Created attachment 186982 [details]
Reworked patch to make the patch application process work. Also fixed all the other style violations that the ews bot was complaining about.
Thanks for the review. Landed in 2 parts: Part 1 r142193: <http://trac.webkit.org/changeset/142193> Part 2 r142194: <http://trac.webkit.org/changeset/142194> |