Bug 109096 – Web Inspector: Add settings checkbox for composited layer borders

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

Web Inspector: Add settings checkbox for composited border layers

Created attachment 186927 [details]
Patch

This should be the last checkbox for now. Pavel, can you please have a look?

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kent Tamura]

Comment on attachment 186927 [details]
Patch

LGTM for WebKit API change

[WebKit Review Bot]

Comment on attachment 186927 [details]
Patch

Clearing flags on attachment: 186927

Committed r142144: <http://trac.webkit.org/changeset/142144>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Timothy Hatcher]

This duplicated API that was already available in the protocol.

            {
                "name": "getCompositingBordersVisible",
                "description": "Indicates the visibility of compositing borders.",
                "returns": [
                    { "name": "result", "type": "boolean", "description": "If true, compositing borders are visible." }
                ],
                "hidden": true
            },
            {
                "name": "setCompositingBordersVisible",
                "description": "Controls the visibility of compositing borders.",
                "parameters": [
                    { "name": "visible", "type": "boolean", "description": "True for showing compositing borders." }
                ],
                "hidden": true
            },

I suggest you remove the one you added. And if you need the "canShow…" call, then add it to make these names.

(In reply to comment #7)
> This duplicated API that was already available in the protocol.
> 
>             {
>                 "name": "getCompositingBordersVisible",
>                 "description": "Indicates the visibility of compositing borders.",
>                 "returns": [
>                     { "name": "result", "type": "boolean", "description": "If true, compositing borders are visible." }
>                 ],
>                 "hidden": true
>             },
>             {
>                 "name": "setCompositingBordersVisible",
>                 "description": "Controls the visibility of compositing borders.",
>                 "parameters": [
>                     { "name": "visible", "type": "boolean", "description": "True for showing compositing borders." }
>                 ],
>                 "hidden": true
>             },
> 
> I suggest you remove the one you added. And if you need the "canShow…" call, then add it to make these names.

Oh, seems like I overlooked that. I will follow your suggestion.