Summary: | [EFL][WK2] Add C API for popup menu and popup item | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, benjamin, cmarcelo, gyuyoung.kim, hausmann, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, pierre.rossi, rakuco, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 108798 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2013-02-06 12:05:33 PST
Created attachment 186890 [details]
WIP Patch
Attachment 186890 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/Shared/API/c/efl/WKBaseEfl.h', u'Source/WebKit2/Shared/APIObject.h', u'Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.cpp', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupMenu.cpp', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupMenu.h', u'Source/WebKit2/UIProcess/efl/PageClientBase.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupItemEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupItemEfl.h', u'Source/WebKit2/UIProcess/efl/WebPopupMenuClient.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupMenuClient.h', u'Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h']" exit_code: 1
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:36: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:37: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:42: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:43: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupMenu.h:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 5 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 186890 [details]
WIP Patch
Should probably have an API test. Would be nice to see how this would work for multi selects
Created attachment 187110 [details]
Patch
Attachment 187110 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/Shared/API/c/efl/WKBaseEfl.h', u'Source/WebKit2/Shared/APIObject.h', u'Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h', u'Source/WebKit2/UIProcess/API/C/efl/WKPageEfl.cpp', u'Source/WebKit2/UIProcess/API/C/efl/WKPageEfl.h', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.cpp', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupMenuListener.cpp', u'Source/WebKit2/UIProcess/API/C/efl/WKPopupMenuListener.h', u'Source/WebKit2/UIProcess/API/efl/EwkView.cpp', u'Source/WebKit2/UIProcess/API/efl/EwkView.h', u'Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_private.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPopupMenuProxy.h', u'Source/WebKit2/UIProcess/efl/PageClientBase.cpp', u'Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp', u'Source/WebKit2/UIProcess/efl/PageUIClientEfl.h', u'Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupItemEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupItemEfl.h', u'Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.h', u'Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h', u'Source/WebKit2/UIProcess/efl/WebUIPopupMenuClient.cpp', u'Source/WebKit2/UIProcess/efl/WebUIPopupMenuClient.h']" exit_code: 1
Source/WebKit2/UIProcess/API/C/efl/WKPageEfl.h:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:36: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:37: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:42: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/efl/WKPopupItem.h:43: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 5 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 187110 [details] Patch Rejecting attachment 187110 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 187110, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: pMenuProxyEfl.cpp rm 'Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp' patching file Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h rm 'Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h' patching file Source/WebKit2/UIProcess/efl/WebUIPopupMenuClient.cpp patching file Source/WebKit2/UIProcess/efl/WebUIPopupMenuClient.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Anders Carlsson']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16611352 It would've been nice if this wasn't all EFL'ed - naturally the other ports need the same functionality (In reply to comment #7) > It would've been nice if this wasn't all EFL'ed - naturally the other ports need the same functionality I see. I wasn't sure other ports needed this. It would be nice to share code with other ports as much as possible. Do you think it would be OK to land this and then later move / rename files as needed when Qt port needs it? The thing is that some things are port specific. For example, the WKPopupMenuListener API is likely going to be different on Qt port. However, things like WKPopupItem, WebPopupItemEfl and likely WebUIPopupMenuClient can certainly be shared. Created attachment 188939 [details]
Patch for landing
Comment on attachment 188939 [details] Patch for landing Clearing flags on attachment: 188939 Committed r143275: <http://trac.webkit.org/changeset/143275> All reviewed patches have been landed. Closing bug. |