Bug 109043

Summary: [chromium] move methods that change initial testRunner state to TestRunner library
Product: WebKit Reporter: jochen
Component: Tools / TestsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91308    
Attachments:
Description Flags
Patch none

jochen
Reported 2013-02-06 05:32:08 PST
Depending on the name of the layout test, we change certain parameters, e.g. dumpAsText() This logic should be part of the TestRunner library
Attachments
Patch (10.67 KB, patch)
2013-02-08 12:30 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-02-08 12:30:03 PST
Created attachment 187349 [details] Patch
WebKit Review Bot
Comment 2 2013-02-08 12:31:20 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2013-02-08 21:12:47 PST
Comment on attachment 187349 [details] Patch This patches are great.
WebKit Review Bot
Comment 4 2013-02-09 10:57:13 PST
Comment on attachment 187349 [details] Patch Clearing flags on attachment: 187349 Committed r142370: <http://trac.webkit.org/changeset/142370>
WebKit Review Bot
Comment 5 2013-02-09 10:57:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.