Bug 109041 – [chromium] move webrtc mocks to testrunner library

• Component: Tools / Tests
• Status: RESOLVED FIXED

for now, we'll stick with the mocks

Created attachment 187526 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 187526 [details]
Patch

Attachment 187526 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16497116

New failing tests:
fast/mediastream/RTCPeerConnection-statsSelector.html
fast/mediastream/RTCPeerConnection-stats.html

[WebKit Review Bot]

Comment on attachment 187526 [details]
Patch

Attachment 187526 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16488225

New failing tests:
fast/mediastream/RTCPeerConnection-statsSelector.html
fast/mediastream/RTCPeerConnection-stats.html

The tests fail because of a bug in webkit_support. Fix here: https://codereview.chromium.org/12212107

[Adam Barth]

Comment on attachment 187526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187526&action=review

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:91
> +    MockWebKitPlatformSupport* getMockPlatform() { return m_mockPlatform.get(); }

getMockPlatform -> mockPlatform (we tend to skip the "get" prefix)

Created attachment 187787 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 187787 [details]
Patch for landing

Clearing flags on attachment: 187787

Committed r142593: <http://trac.webkit.org/changeset/142593>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.