Bug 10903

Summary:

Yet Another Objective-C Bindings Patch

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	timothy: review-
patch with Tim's comments addressed	none
patch with Tim's comments addressed	timothy: review-
patch with all of Tim's comments addressed	timothy: review+

Sam Weinig

Reported 2006-09-17 12:51:01 PDT

Some of this, some of that. Patch forthcoming.

Attachments
patch (106.22 KB, patch) 2006-09-17 14:12 PDT, Sam Weinig	timothy: review-	Details Formatted Diff Diff
patch with Tim's comments addressed (105.53 KB, patch) 2006-09-17 19:34 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
patch with Tim's comments addressed (105.53 KB, patch) 2006-09-17 19:34 PDT, Sam Weinig	timothy: review-	Details Formatted Diff Diff
patch with all of Tim's comments addressed (106.42 KB, patch) 2006-09-18 12:58 PDT, Sam Weinig	timothy: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2006-09-17 14:12:09 PDT

Created attachment 10608 [details] patch - Whitespace cleanup for IDLParser.pm - Add conditional #ifdefs (ie. #ifdef SVG_SUPPORT) to auto-generated implementation files. - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException and DOMAbstractView into their own files. - Remove private method [DOMRGBColor _color] from DOMPrivate.h asit is not used and a public method is available now. - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h as it not used. - Auto-generate method isContentEditable for DOMNode. - General cleanup of bindings code including removing unneeded #imports and whitespace cleanup.

Timothy Hatcher

Comment 2 2006-09-17 14:45:27 PDT

Comment on attachment 10608 [details] patch +#import <WebCore/DOMDOMImplementation.h> THis was in the original order because once in WebKit is will be: #import <WebCore/DOMImplementation.h> So the order in WeCore is wrong but it will be right once in WebKit. DOMObject.h needs to include DOMException.h since you removed the enum from there. isContentEditable should be for ObjC only. This naming schee is only common in ObjC (with the "is" prefix for boolean types.) Other languages should just be "bool contentEditible". I am fine keeping isContentEditable as a hand implemented method.

Sam Weinig

Comment 3 2006-09-17 19:34:13 PDT

Created attachment 10614 [details] patch with Tim's comments addressed

Sam Weinig

Comment 4 2006-09-17 19:34:18 PDT

Created attachment 10615 [details] patch with Tim's comments addressed

Timothy Hatcher

Comment 5 2006-09-17 22:06:50 PDT

Comment on attachment 10615 [details] patch with Tim's comments addressed The #import <WebCore/DOMDOMImplementation.h> should not be moved. DOMObject.h still needs to import DOMException.h since the exceptions are being removed from that header. We can't move them unless someone that includes DOMObject.h still gets the exception enums.

Timothy Hatcher

Comment 6 2006-09-17 22:07:03 PDT

r=me otherwise

Sam Weinig

Comment 7 2006-09-18 12:58:04 PDT

Created attachment 10633 [details] patch with all of Tim's comments addressed

Sam Weinig

Comment 8 2006-09-18 14:35:31 PDT

Landed in r16438.

Note You need to log in before you can comment on or make changes to this bug.