Bug 109029

Summary: Add an ENABLE_NOSNIFF feature flag.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, abecsi, dbates, gyuyoung.kim, jochen, rakuco, tsepez, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71851    
Attachments:
Description Flags
Patch none

Description Mike West 2013-02-06 01:32:32 PST 
Before reviving the x-content-type-options patch, we should add a flag, as discussed at https://lists.webkit.org/pipermail/webkit-dev/2011-November/018557.html way back in the depths of 2011.

I'll enable it for the Chromium port, and disable it for all others.
Comment 1 Mike West 2013-02-06 01:38:56 PST 
Created attachment 186789 [details]
Patch
Comment 2 Mike West 2013-02-06 01:40:45 PST 
Jochen, perhaps you could take a look at this?

The original discussion was way back in 2011; no one expressed objections at that time. I've pinged the list again to notify folks that we're kicking at this again. I don't anticipate negative responses this time around.
Comment 3 jochen 2013-02-06 01:51:46 PST 
Comment on attachment 186789 [details]
Patch

r=me
Comment 4 Mike West 2013-02-06 02:09:43 PST 
(In reply to comment #3)
> (From update of attachment 186789 [details])
> r=me

Once the other ports' bots catch up, I'll CQ the patch. Thanks!
Comment 5 WebKit Review Bot 2013-02-06 04:08:47 PST 
Comment on attachment 186789 [details]
Patch

Clearing flags on attachment: 186789

Committed r141985: <http://trac.webkit.org/changeset/141985>
Comment 6 WebKit Review Bot 2013-02-06 04:08:54 PST 
All reviewed patches have been landed.  Closing bug.