Bug 109026

Summary:

[V8] Make an Isolate parameter mandatory in GetTemplate() and GetRawTemplate()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, alecflett, dglazkov, dgrogan, eric.carlson, feature-media-reviews, japhet, jsbell, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Kentaro Hara

Reported 2013-02-06 01:09:04 PST

Now it's time to kill an optional Isolate parameter.

Attachments
Patch (52.14 KB, patch) 2013-02-06 01:10 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (53.06 KB, patch) 2013-02-06 03:16 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (54.08 KB, patch) 2013-02-06 03:18 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2013-02-06 01:10:03 PST

Created attachment 186780 [details] Patch

Build Bot

Comment 2 2013-02-06 02:20:48 PST

Comment on attachment 186780 [details] Patch Attachment 186780 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16397068

WebKit Review Bot

Comment 3 2013-02-06 02:28:25 PST

Comment on attachment 186780 [details] Patch Attachment 186780 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16390180 New failing tests: accessibility/aria-checkbox-checked.html animations/3d/matrix-transform-type-animation.html http/tests/appcache/cyrillic-uri.html accessibility/anchor-linked-anonymous-block-crash.html animations/animation-add-events-in-handler.html http/tests/appcache/deferred-events-delete-while-raising.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html http/tests/appcache/deferred-events-delete-while-raising-timer.html accessibility/aria-describedby-on-input.html http/tests/appcache/crash-when-navigating-away-then-back.html animations/animation-border-overflow.html animations/animation-direction-alternate-reverse.html accessibility/accessibility-object-detached.html http/tests/appcache/abort-cache-ondownloading-manifest-404.html http/tests/appcache/credential-url.html animations/animation-controller-drt-api.html animations/3d/change-transform-in-end-event.html accessibility/aria-controls-with-tabs.html canvas/philip/tests/2d.canvas.readonly.html animations/3d/transform-perspective.html accessibility/accessibility-node-reparent.html http/tests/appcache/access-via-redirect.php http/tests/appcache/deferred-events.html animations/3d/state-at-end-event-transform.html animations/animation-direction-normal.html animations/3d/transform-origin-vs-functions.html accessibility/accessibility-node-memory-management.html animations/animation-css-rule-types.html accessibility/adjacent-continuations-cause-assertion-failure.html

Kentaro Hara

Comment 4 2013-02-06 03:16:17 PST

Created attachment 186811 [details] Patch

Kentaro Hara

Comment 5 2013-02-06 03:18:08 PST

Created attachment 186813 [details] Patch

WebKit Review Bot

Comment 6 2013-02-06 18:45:33 PST

Comment on attachment 186813 [details] Patch Clearing flags on attachment: 186813 Committed r142061: <http://trac.webkit.org/changeset/142061>

WebKit Review Bot

Comment 7 2013-02-06 18:45:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.