Bug 109020 – input element with placeholder text and width set to 100% on focus causes overflow even after losing focus

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Masataka Yakura]

Created attachment 186775 [details]
test case

Steps to reproduce:
1. open the attachment
2. hit Tab key to focus the input element
3. hit Tab again to move focus out from the input element

Expected results:
there is no horizontal scrollbar.

What happened instead:
there is a horizontal scrollbar.

This neither happens on input elements with no placeholder text (or blank placeholder text) nor textarea elements with or without placeholder text.

[Robert Hogan]

Created attachment 188703 [details]
Patch

[Darin Adler]

Comment on attachment 188703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188703&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1698
> +    if (block->node() && block->node()->toInputElement() && block->node()->toInputElement()->placeholderElement() && block->node()->toInputElement()->placeholderElement()->renderer() == child)
> +        return false;

There has to be some better way of doing this than hard-coding the placeholder. Is a placeholder element really the only place in all of WebKit that we have block child that does not affect layout or size of the parent? Is there a better way to set up the render tree so we don’t need this very-specific hack?

[Robert Hogan]

Created attachment 188928 [details]
Patch

[Dave Hyatt]

Comment on attachment 188928 [details]
Patch

This seems ok. Other approaches you could take would be to simply recompute overflow if the placeholder box does a relayout. This would be better if the placeholder needs to contribute to overflow and doing this causes it to be wrong. It seems like a bug that the placeholder is getting resized but nobody recomputes overflow?

[Robert Hogan]

Created attachment 188931 [details]
Patch

[Dave Hyatt]

Comment on attachment 188931 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 188931 [details]
Patch

Rejecting attachment 188931 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
Full output: http://queues.webkit.org/results/16621955

[WebKit Review Bot]

Comment on attachment 188931 [details]
Patch

Clearing flags on attachment: 188931

Committed r143475: <http://trac.webkit.org/changeset/143475>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.