| Summary: | <hr> should expose AXRole/AXSubrole, etc | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||||||
| Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, faulkner.steve, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer | ||||||||||||
| Priority: | P4 | Keywords: | InRadar | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
James Craig
2013-02-05 23:59:24 PST
<hr> should use: AXRole: AXSplitter AXSubrole: AXContentSeparator AXRoleDescription: "separator" AXEnabled: NO AXValue: not-writeable Created attachment 227360 [details]
patch
Comment on attachment 227360 [details] patch Attachment 227360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5762691201236992 New failing tests: accessibility/roles-exposed.html accessibility/lists.html Created attachment 227367 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 227360 [details] patch Attachment 227360 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6229837614153728 New failing tests: accessibility/roles-exposed.html http/tests/media/track/track-webvtt-slow-loading.html accessibility/lists.html Created attachment 227369 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 227360 [details] patch Attachment 227360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4963200218955776 New failing tests: accessibility/roles-exposed.html http/tests/media/track/track-webvtt-slow-loading.html accessibility/lists.html Created attachment 227370 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 227360 [details] patch Attachment 227360 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6072248016306176 New failing tests: accessibility/roles-exposed.html http/tests/media/track/track-webvtt-slow-loading.html accessibility/lists.html Created attachment 227373 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 227360 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=227360&action=review Besides a couple of nits mentioned below, the patch looks good to me. It is very weird, though, that you got those failures in the mac EWS bots, since the it seemed to me (after looking through the actual results zipped in previous comments) that the EWS were not picking, for whatever reason, the new expected results you are providing with your patch (which are identical to the diff provided by the EWS as "proof of failure") Thus, would you mind addressing those nits and also making sure there's nothing wrong with the new expectations for mac before landing? Thanks! > Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp:-46 > - if (role == HorizontalRuleRole) > - return IncludeObject; Nit. Could you move the declaration above down right before the first use of role? > LayoutTests/ChangeLog:12 > + * platform/gtk/accessibility/roles-exposed-expected.txt: Added. You don't need to add a expectation for GTK. I believe that the one in accessibility/roles-exposed-expected.txt should still work for GTK and EFL > LayoutTests/accessibility/lists.html:28 > + <BR><BR><BR><BR> I guess this change will probably mean a rebaseline for GTK/EFL later on. I'll keep an eye on that (In reply to comment #12) > (From update of attachment 227360 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227360&action=review > Thanks. Will make all these changes > Besides a couple of nits mentioned below, the patch looks good to me. It is very weird, though, that you got those failures in the mac EWS bots, since the it seemed to me (after looking through the actual results zipped in previous comments) that the EWS were not picking, for whatever reason, the new expected results you are providing with your patch (which are identical to the diff provided by the EWS as "proof of failure") > > Thus, would you mind addressing those nits and also making sure there's nothing wrong with the new expectations for mac before landing? Thanks! > > > Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp:-46 > > - if (role == HorizontalRuleRole) > > - return IncludeObject; > > Nit. Could you move the declaration above down right before the first use of role? > > > LayoutTests/ChangeLog:12 > > + * platform/gtk/accessibility/roles-exposed-expected.txt: Added. > > You don't need to add a expectation for GTK. I believe that the one in accessibility/roles-exposed-expected.txt should still work for GTK and EFL > > > LayoutTests/accessibility/lists.html:28 > > + <BR><BR><BR><BR> > > I guess this change will probably mean a rebaseline for GTK/EFL later on. I'll keep an eye on that Probably. Thanks! *** Bug 134027 has been marked as a duplicate of this bug. *** |