Bug 10901

Summary: Merge build fixes from unity
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: OS X 10.4   
Attachments:
Description Flags
CMake build fox
eric: review+
Add qmake 2 support for building the WebKit lib none

Rob Buis
Reported 2006-09-17 09:17:50 PDT
Recently there were fixes for building unity using cmake and qmake. Merge these commits into webkit.
Attachments
CMake build fox (4.29 KB, patch)
2006-09-17 09:35 PDT, Rob Buis 		eric: review+
DetailsFormatted DiffDiff
Add qmake 2 support for building the WebKit lib (51.16 KB, patch)
2006-11-03 03:33 PST, Enrico Ros 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2006-09-17 09:35:34 PDT
Created attachment 10606 [details] CMake build fox This patch should fix compilation of generated cpp files using cmake. Cheers, Rob.
Eric Seidel (no email)
Comment 2 2006-09-18 21:11:01 PDT
Comment on attachment 10606 [details] CMake build fox I have no trouble with the fix itself. Although I wonder if something more clever could be done...
Eric Seidel (no email)
Comment 3 2006-09-21 14:34:12 PDT
Comment on attachment 10606 [details] CMake build fox It seems silly to hold up landing this any longer. Yes, it's an in-elegant solution, but if it fixes the unity build issues, that's fine. r=me.
Rob Buis
Comment 4 2006-09-22 01:24:04 PDT
Landed in r16519.
Enrico Ros
Comment 5 2006-11-03 03:33:49 PST
Created attachment 11360 [details] Add qmake 2 support for building the WebKit lib Here is the patch to add support for building a 'WebKitQt' library from JavaScriptCore and WebCore trees. It compiles core stuff plus everything that is PLATFORM(QT). The lib is build by: - webkit-qt.pro - JavaScriptCore / JavaScriptCore.pri - JavaScriptCore / pcre / PCRE.pri - WebCore / WebCore.pri supporting conditionals for XPATH, XSLT, XBL, SVG. An additional webkit-qt.pri makes it easy for applications to build with the generated library. Thanks to tronical for getting it ready for inclusion.
Note You need to log in before you can comment on or make changes to this bug.