| Summary: | Negative text indents can break RenderBlock's inline maximum preferred width calculation | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||||||
| Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eae, eric, mitz, ojan.autocc, robert, webkit.review.bot, zan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Levi Weintraub
2013-02-05 12:59:56 PST
Created attachment 186685 [details]
Test case
Created attachment 186891 [details]
Patch
Comment on attachment 186891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186891&action=review Have you tested this for rtl content and with a negative margin-right? > Source/WebCore/rendering/RenderBlock.cpp:5873 > + // Only gets added to the max preffered width once. typo, s/preffered/preferred/ Created attachment 186916 [details]
Patch
Comment on attachment 186916 [details] Patch Clearing flags on attachment: 186916 Committed r142042: <http://trac.webkit.org/changeset/142042> All reviewed patches have been landed. Closing bug. The layout test added in this patch is failing on GTK. Could the failure be caused by the subpixel layout being disabled? For reference, here's the expected and actual image output. http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r142063%20(34139)/fast/css/negative-text-indent-in-inline-block-diffs.html That looks like a subpixel alignment issue. The good news is that there is no line break though. |