Bug 10896

Summary: REGRESSION: WebKit can't be built with SVG disabled
Product: WebKit Reporter: Graham Dennis <Graham.Dennis>
Component: New BugsAssignee: Graham Dennis <Graham.Dennis>
Status: RESOLVED FIXED    
Severity: Normal CC: dwood
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch eric: review+

Graham Dennis
Reported 2006-09-17 05:32:29 PDT
The build-bot is failing to compile WebKit without SVG and it is failing while compiling DerivedSources/WebCore/DOMXPathExpression.mm which shouldn't exist in the no-SVG build. I have tested this locally, and have run into the same problem.
Attachments
patch (4.34 KB, patch)
2006-09-17 06:57 PDT, Graham Dennis 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Graham Dennis
Comment 1 2006-09-17 06:57:29 PDT
Created attachment 10603 [details] patch The problem is not that DerivedSources/WebCore/DOMXPathExpression.mm shouldn't exist, but that it should have a #ifdef XPATH_SUPPORT at the start of the file. This is a general problem for the ObjC generated code that have the Conditional extended attribute set. This patch modifies CodeGeneratorObjC.pm to add #ifdef / #endif pairs to the appropriate files.
Eric Seidel (no email)
Comment 2 2006-09-18 02:05:40 PDT
Comment on attachment 10603 [details] patch Looks good to me. r=me
Eric Seidel (no email)
Comment 3 2006-09-18 02:06:18 PDT
Comment on attachment 10603 [details] patch You should probably add your copyright to the files however.
Mark Rowe (bdash)
Comment 4 2006-09-18 02:10:59 PDT
Landed in r16420.
Note You need to log in before you can comment on or make changes to this bug.