Bug 108958

Summary: [Windows] VS2010 JavaScriptCore putting Import library in wrong place
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: JavaScriptCoreAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Blocker CC: jonlee, roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2013-02-05 10:35:08 PST
The currently checked-in version of the JavaScriptCore project is building the JavaScriptCore.lib library and placing it in $(ConfigurationBuildDir)\bin, instead of $(ConfigurationBuildDir)\lib. This prevents other things (like JSC) from building. It looks like the revamped VS2010 common property sheet is missing the Linker export settings used in the VS2005 version of the file. This patch corrects this oversight.
Attachments
Patch (1.20 KB, patch)
2013-02-05 10:40 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-02-05 10:40:14 PST
Created attachment 186657 [details] Patch
Brent Fulgham
Comment 2 2013-04-15 13:02:33 PDT
Comment on attachment 186657 [details] Patch Roger fixed this in a different commit.
Note You need to log in before you can comment on or make changes to this bug.