Bug 108937

Summary:

[Qt] Broken build for WebCore qt/tests since r141598

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Major

CC:

allan.jensen, hausmann, jturcotte

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Build fix	jbriance: review-

Julien Brianceau

Reported 2013-02-05 06:34:44 PST

WebCore qt/tests build is broken since r141598 Seen with our sh4 build slave: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/19293/steps/compile-webkit/logs/stdio

Attachments
Build fix (1.12 KB, patch) 2013-02-05 06:40 PST, Julien Brianceau	jbriance: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-02-05 06:40:31 PST

Created attachment 186617 [details] Build fix

Simon Hausmann

Comment 2 2013-02-05 07:26:30 PST

Comment on attachment 186617 [details] Build fix Did you want to set r? instead of r-?

Jocelyn Turcotte

Comment 3 2013-02-05 07:35:23 PST

I think that his Qt is old or something, QSignalSpy takes a const QObject* since October in qtbase from what I've seen.

Julien Brianceau

Comment 4 2013-02-05 07:36:59 PST

(In reply to comment #2) > (From update of attachment 186617 [details]) > Did you want to set r? instead of r-? No, the r- is my intention (thanks to Allan). QSignalSpy prototype changed in Qt5 (in commit id 80ae1d2078d2fe137f8a88268c66440bf19bc1ba) and our build slave doesn't seem to be up to date.. I'm going to update our bot and see if it's better, I'll keep you informed.

Julien Brianceau

Comment 5 2013-02-05 11:21:08 PST

That's it. The qt5 build was too old in our build slave. I performed a fast-forward to the qt5 5.0.0 release (git tag "v5.0.0") and now it's ok: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/19306 Thanks and sorry for the noise

Note You need to log in before you can comment on or make changes to this bug.