Bug 10889
| Summary: | the ownerDocument method in DOMNode should call ownerDocument() not document() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | darin |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Sam Weinig
The ownerDocument method for the Objective-C binding for DOMNode calls the implementation method document() instead of ownerDocument(). The spec says that we should be using the logic of ownerDocument(). The issue is that there might be people who depend on this behavior (we ourselves in fact do).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Easy fix?
Darin Adler
It’s easy to make this change, but then it would break clients who rely on the current behavior of returning self for Document. I suggest leaving this in the current Objective-C DOM bindings, but removing it if we ever have a chance to make a fresh start with a compatibility break.
Sam Weinig
Not worth doing.