Bug 108884 – NRWT: confusing warning about a line being in a Skipped file when it is really just listed in _missing_symbol_to_skipped_tests in base.py

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jessie Berlin]

When running run-webkit-tests, I am seeing the following warnings:

LayoutTests/platform/mac/TestExpectations:1033 /Volumes/Users/jessieberlin/Source/Safari/Opensource/LayoutTests/platform/mac/TestExpectations:1033 fast/css/variables is also in a Skipped file. fast/css/variables
LayoutTests/platform/mac/TestExpectations:1034 /Volumes/Users/jessieberlin/Source/Safari/Opensource/LayoutTests/platform/mac/TestExpectations:1034 inspector/styles/variables is also in a Skipped file. inspector/styles/variables

This is happening because ‘fast/css/variables’ and ‘inspector/styles/variables’ are listed in _missing_symbol_to_skipped_tests as well as being listed in that TestExpectations file.

    # Ports which use compile-time feature detection should define this method and return                                                                                                                                             
    # a dictionary mapping from symbol substrings to possibly disabled test directories.                                                                                                                                              
    # When the symbol substrings are not matched, the directories will be skipped.                                                                                                                                                    
    # If ports don't ever enable certain features, then those directories can just be                                                                                                                                                 
    # in the Skipped list instead of compile-time-checked here.                                                                                                                                                                       
    def _missing_symbol_to_skipped_tests(self):
        """Return the supported feature dictionary. The keys are symbol-substrings                                                                                                                                                    
        and the values are the lists of directories to skip if that symbol is missing."""
        return {
            "MathMLElement": ["mathml"],
            "GraphicsLayer": ["compositing"],
            "WebCoreHas3DRendering": ["animations/3d", "transforms/3d"],
            "WebGLShader": ["fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "webgl"],
            "MHTMLArchive": ["mhtml"],
            "CSSVariableValue": ["fast/css/variables", "inspector/styles/variables"],
        }

I talked with Eric Seidel and Dirk Pranke about this on IRC. We should just remove this code. ORWT used to detect if you had SVG compiled into your binary and auto-skip relevant tests, and this was added to support that. Dirk also noted "there's a separate similar code path for "runtime" feature detection that IIRC was only needed for the apple win port and probably never really worked right there, either."

[Eric Seidel (no email)]

This was a cool feature, but I think it's day is over.

It's very similar to the run-time feature detection used by the AppleWin port in ORWT (where RWT asks DRT what features it supports at runtime).

[Jessie Berlin]

Created attachment 199313 [details]
Patch

[Tim Horton]

Comment on attachment 199313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199313&action=review

> LayoutTests/platform/mac/TestExpectations:1164
> +mhtml [ Skip ]

What about the other platforms? Do they enable all the features listed below?

[Jessie Berlin]

(In reply to comment #3)
> (From update of attachment 199313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199313&action=review
> 
> > LayoutTests/platform/mac/TestExpectations:1164
> > +mhtml [ Skip ]
> 
> What about the other platforms? Do they enable all the features listed below?

I was hoping that EWS would tell me that.

[WebKit Commit Bot]

Comment on attachment 199313 [details]
Patch

Clearing flags on attachment: 199313

Committed r148996: <http://trac.webkit.org/changeset/148996>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.