Bug 108869

Summary: [EFL] Remove needless local variables in LocalizedStringsEfl.cpp
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2013-02-04 15:19:13 PST
fromUTF8() returns *static String*, so I think we don't need to use local variable. Beside it seems to me the functions which use *static String variable* were just copied from GTK port. If possible, I think it would be better not to use local variable.
Attachments
Patch (3.73 KB, patch)
2013-02-04 15:20 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-02-04 15:20:31 PST
Created attachment 186475 [details] Patch
Kentaro Hara
Comment 2 2013-02-04 15:54:11 PST
Comment on attachment 186475 [details] Patch Looks reasonable
WebKit Review Bot
Comment 3 2013-02-04 18:14:20 PST
Comment on attachment 186475 [details] Patch Clearing flags on attachment: 186475 Committed r141842: <http://trac.webkit.org/changeset/141842>
WebKit Review Bot
Comment 4 2013-02-04 18:14:24 PST
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 5 2013-02-05 09:07:17 PST
(In reply to comment #0) > fromUTF8() returns *static String*, so I think we don't need to use local variable. For the record, `static' here is just a modifier that indicates that that method is not per class, but rather per class instance. WTFString::fromUTF8() returns a String, not a "static String".
Kentaro Hara
Comment 6 2013-02-05 15:33:03 PST
(In reply to comment #5) > (In reply to comment #0) > > fromUTF8() returns *static String*, so I think we don't need to use local variable. > > For the record, `static' here is just a modifier that indicates that that method is not per class, but rather per class instance. WTFString::fromUTF8() returns a String, not a "static String". Good point. You're right...
Gyuyoung Kim
Comment 7 2013-02-05 15:45:00 PST
(In reply to comment #5) > (In reply to comment #0) > > fromUTF8() returns *static String*, so I think we don't need to use local variable. > > For the record, `static' here is just a modifier that indicates that that method is not per class, but rather per class instance. WTFString::fromUTF8() returns a String, not a "static String". My mistake. Thank you for your point out.
Note You need to log in before you can comment on or make changes to this bug.