Bug 108855

Summary: [WK2] CoordinatedGraphicsLayerState is a struct, not a class
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: WebKit2Assignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review+
Patch for landing none

Bruno Abinader (history only)
Reported 2013-02-04 13:31:28 PST
Some forward declarations of CoordinatedLayerInfo were stating it is a class, but in fact it is a struct.
Attachments
Patch (2.83 KB, patch)
2013-02-04 13:34 PST, Bruno Abinader (history only) 		kling: review+
DetailsFormatted DiffDiff
Patch for landing (1.44 KB, patch)
2013-04-18 06:37 PDT, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2013-02-04 13:34:34 PST
Created attachment 186449 [details] Patch Proposed patch
Noam Rosenthal
Comment 2 2013-02-04 13:45:46 PST
Comment on attachment 186449 [details] Patch Since this is trivial I take the liberty to r+ it :)
Noam Rosenthal
Comment 3 2013-02-04 14:07:54 PST
Comment on attachment 186449 [details] Patch Clearing r+, since apparently it's not ok to r+ trivial patches anymore.
Andreas Kling
Comment 4 2013-04-18 06:09:13 PDT
Comment on attachment 186449 [details] Patch rs=me
Bruno Abinader (history only)
Comment 5 2013-04-18 06:33:07 PDT
CoordinatedLayerInfo has changed to CoordinatedGraphicsLayerState in r144787, but the forward declaration issue is still valid. I'm rebasing the patch for landing atm.
Bruno Abinader (history only)
Comment 6 2013-04-18 06:37:39 PDT
Created attachment 198730 [details] Patch for landing
WebKit Commit Bot
Comment 7 2013-04-18 07:06:50 PDT
Comment on attachment 198730 [details] Patch for landing Clearing flags on attachment: 198730 Committed r148674: <http://trac.webkit.org/changeset/148674>
Bruno Abinader (history only)
Comment 8 2013-04-25 21:42:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.