Bug 108848 – Disable autoscrolling the main frame if main frame scrolling is disabled

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Tim Horton]

If main frame scrolling is disabled, you can still cause the main frame to scroll via autoscrolling (drag selection, etc.). This seems wrong.

<rdar://problem/13004059>

[Tim Horton]

Created attachment 186435 [details]
patch

[Tim Horton]

http://trac.webkit.org/changeset/141792

[Darin Adler]

Comment on attachment 186435 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186435&action=review

> Source/WebCore/rendering/RenderBox.cpp:755
> +    return page && page->mainFrame() == frame && frame->view()->isScrollable();

Can frame->view() ever be null? Can frame->view() every be a view that is currently hosting a different frame?

[Tim Horton]

(In reply to comment #3)
> (From update of attachment 186435 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186435&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:755
> > +    return page && page->mainFrame() == frame && frame->view()->isScrollable();
> 
> Can frame->view() ever be null? Can frame->view() every be a view that is currently hosting a different frame?

I don't think either of those things can be true while we're also dispatching events to the page (I just followed all of the callers and that's the only way we get here), though I could be wrong. That seems scary for other reasons, though.