Bug 108843

Summary: Objective-C API: ObjCCallbackFunction should retain the target of its NSInvocation
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Mark Hahnenberg
Reported 2013-02-04 11:33:12 PST
Currently, ObjCCallbackFunction doesn't retain the target of its NSInvocation. It needs to do this to prevent crashes when trying to invoke a callback later on.
Attachments
Patch (1.59 KB, patch)
2013-02-04 11:43 PST, Mark Hahnenberg 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-02-04 11:33:35 PST
<rdar://problem/13145610>
Mark Hahnenberg
Comment 2 2013-02-04 11:43:06 PST
Created attachment 186425 [details] Patch
Darin Adler
Comment 3 2013-02-04 11:45:17 PST
Is there a reason we can’t use -[NSInvocation retainArguments]?
Mark Hahnenberg
Comment 4 2013-02-04 12:04:08 PST
(In reply to comment #3) > Is there a reason we can’t use -[NSInvocation retainArguments]? I think the issue with retainArguments would be the fact that the arguments to the NSInvocation object aren't constant. We fill in the arguments right as we're about to invoke the callback. If we didn't clear out all the arguments after the invocation, those JSValues would sit around until the next time somebody overwrote the old values when calling the callback again later.
Mark Hahnenberg
Comment 5 2013-02-04 13:40:22 PST
Landed in http://trac.webkit.org/changeset/141805.
Note You need to log in before you can comment on or make changes to this bug.