Bug 10882

Summary: SVG needs Obj-C DOM bindings
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: sam, timothy
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 5392    
Attachments:
Description Flags
patch
none
patch 2
timothy: review+
patch 3 timothy: review+

Eric Seidel (no email)
Reported 2006-09-16 01:34:57 PDT
SVG needs Obj-C DOM bindings This shouldn't be very hard since all of the SVG DOM bindings are auto-generated, and all of the SVG JS DOM bindings are back in working order. The only "challenge" in this patch will be adding multiple inheritance support to the Obj-C DOM binding generator. I would suggest using Obj-C protocols.
Attachments
patch (50.16 KB, patch)
2006-09-24 13:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
patch 2 (52.11 KB, patch)
2006-09-24 13:46 PDT, Sam Weinig 		timothy: review+
DetailsFormatted DiffDiff
patch 3 (42.51 KB, patch)
2006-09-24 15:16 PDT, Sam Weinig 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-09-24 13:38:42 PDT
Created attachment 10741 [details] patch - Auto-generate the first 8 Objective-C SVG DOM bindings. The auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList, DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and DOMSVGTransformList.
Sam Weinig
Comment 2 2006-09-24 13:46:00 PDT
Created attachment 10742 [details] patch 2 Updated patch. Had forgotten to svn add DOMSVG.h.
Timothy Hatcher
Comment 3 2006-09-24 14:48:39 PDT
Comment on attachment 10742 [details] patch 2 Looks good. I would sugest removing "core::" from core::DOMException. We should be consitent, and we use DOMException more than core::DOMException. r=me either way.
Sam Weinig
Comment 4 2006-09-24 15:16:41 PDT
Created attachment 10744 [details] patch 3 Updated Patch. Removes previously commented out "setter raises(DOMException)" statements after a conversation with Wildfox on IRC about it.
Sam Weinig
Comment 5 2006-09-26 06:01:56 PDT
Landed in r 16551.
Note You need to log in before you can comment on or make changes to this bug.