Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent

• Component: DOM
• Status: RESOLVED FIXED

[Kent Tamura]

and need to add it to the followings too.
  Node::dispatchFocusEvent
  Document::setFocusedNode
  FocusController::setFocusedNode
  Element::focus

[Kent Tamura]

Created attachment 186281 [details]
Patch

[Build Bot]

Comment on attachment 186281 [details]
Patch

Attachment 186281 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16357805

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 186281 [details])
> Attachment 186281 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16357805

Looks like APPLE-EWS-2 is damaged. Other patches failed with the same error.

[Hayato Ito]

Comment on attachment 186281 [details]
Patch

Unofficial r=me on this.

Looks okay. I am wondering how many buit-in elements will need this FocusDirection argument.
It seems every built-in elements which has focusable elements in its shadow tree requires this hack to focus elements in shadow tree if a host is focused. e.g. <video> elements.

If so, it might be better to have a general technique to dispatch focus to an element in shadow tree for built-in elements. But that should be out of scope of this patch, I think.


View in context: https://bugs.webkit.org/attachment.cgi?id=186281&action=review

> Source/WebCore/ChangeLog:44
> +        Add FocusDirection argument in order to apss it to Document::setFocusedNode.

apss -> pass

> Source/WebCore/html/HTMLLegendElement.h:44
> +    virtual void focus(bool, FocusDirection) OVERRIDE;

bool -> bool restorePreviousSelection

[Hajime Morrita]

Comment on attachment 186281 [details]
Patch

rs=me based on hayato's r.

[Kent Tamura]

Created attachment 186290 [details]
Patch for landing

Fixed a typo and add an argument name to HTMLLegendElement.h

[WebKit Review Bot]

Comment on attachment 186290 [details]
Patch for landing

Rejecting attachment 186290 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 186290, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Hajime Morrita found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16358916

[Kent Tamura]

Created attachment 186291 [details]
Patch for landing 2

Morrita

[WebKit Review Bot]

Comment on attachment 186291 [details]
Patch for landing 2

Clearing flags on attachment: 186291

Committed r141738: <http://trac.webkit.org/changeset/141738>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.