Summary: | FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Nordman <michaeln> | ||||||
Component: | WebCore Misc. | Assignee: | Michael Nordman <michaeln> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 108733, 108851 | ||||||||
Attachments: |
|
Description
Michael Nordman
2013-02-01 18:13:35 PST
Created attachment 186200 [details]
api
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 186200 [details] api Rejecting attachment 186200 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 186200, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16355229 Comment on attachment 186200 [details] api View in context: https://bugs.webkit.org/attachment.cgi?id=186200&action=review > Source/WebKit/chromium/ChangeLog:7 > + https://bugs.webkit.org/show_bug.cgi?id=108736 Looks like this ChangeLog is missing the "Reviewed by NOBODY (OOPS!)." line Created attachment 186248 [details]
Patch for landing
Comment on attachment 186248 [details] Patch for landing Clearing flags on attachment: 186248 Committed r141712: <http://trac.webkit.org/changeset/141712> All reviewed patches have been landed. Closing bug. |