Bug 108734

Summary: Fixed and sticky nodes have no nodeID set
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, jamesr, simon.fraser, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2013-02-01 18:06:12 PST
Fixed and sticky nodes in the scrolling tree have m_nodeID set to 0, which seems wrong (but harmless).
Attachments
Patch (14.50 KB, patch)
2013-02-01 21:13 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-02-01 18:07:59 PST
@@ -182,6 +183,7 @@ void ScrollingTree::updateTreeFromStateNode(ScrollingStateNode* stateNode) newNode->setParent(parent); parent->appendChild(newNode.release()); } + newNodeRawPtr->setScrollingNodeID(stateNode->scrollingNodeID()); newNodeRawPtr->update(stateNode); } }
Simon Fraser (smfr)
Comment 2 2013-02-01 21:13:34 PST
Created attachment 186213 [details] Patch
WebKit Review Bot
Comment 3 2013-02-02 13:04:52 PST
Comment on attachment 186213 [details] Patch Clearing flags on attachment: 186213 Committed r141703: <http://trac.webkit.org/changeset/141703>
WebKit Review Bot
Comment 4 2013-02-02 13:04:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.