Bug 108659

Summary:

Structure should have a StructureRareData field to save space

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, philn, rakuco, webkit-ews, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	oliver: review+
perf results	none

Mark Hahnenberg

Reported 2013-02-01 10:43:46 PST

Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields. To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData if it has one. There could be some potential for optimizing this process, but the initial implementation will be dumb since we'd be paying these overhead costs for each Structure anyways. Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from Structures (and into StructureRareData).

Attachments
Patch (38.83 KB, patch) 2013-02-01 12:00 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (43.49 KB, patch) 2013-02-01 12:34 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (42.93 KB, patch) 2013-02-01 14:21 PST, Mark Hahnenberg	oliver: review+	Details Formatted Diff Diff
perf results (19.08 KB, text/plain) 2013-02-01 14:56 PST, Mark Hahnenberg	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.