Bug 10865

Summary: New file upload control should match the width of the old one
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: FormsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Fix: Reduce width and update tests
timothy: review+
Patch w/ updated results for all affected tests timothy: review+

Adam Roben (:aroben)
Reported 2006-09-14 21:07:02 PDT
The new file upload control is (by default) a bit wider than the old one. It should match the old one as closely as possible.
Attachments
Fix: Reduce width and update tests (2.73 KB, patch)
2006-09-14 21:09 PDT, Adam Roben (:aroben) 		timothy: review+
DetailsFormatted DiffDiff
Patch w/ updated results for all affected tests (26.86 KB, patch)
2006-09-15 10:54 PDT, Adam Roben (:aroben) 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2006-09-14 21:09:01 PDT
Created attachment 10570 [details] Fix: Reduce width and update tests This patch reduces the width of the file upload control so that it is only 2px bigger than the old one, and updates the relevant layout test.
Adam Roben (:aroben)
Comment 2 2006-09-15 10:54:43 PDT
Created attachment 10577 [details] Patch w/ updated results for all affected tests This patch has the same fix as the previous one, but regenerates the results for 3 additional tests that were failing because of the new control.
Timothy Hatcher
Comment 3 2006-09-15 14:49:12 PDT
Comment on attachment 10577 [details] Patch w/ updated results for all affected tests r=me, update the LayoutTests/ChangeLog to reflect the new test changes.
Adam Roben (:aroben)
Comment 4 2006-09-15 15:05:07 PDT
Landed as r16373.
Note You need to log in before you can comment on or make changes to this bug.