Bug 108647

Summary: ScrollAnimatorMac should adopt contentAreaScrolledInDirection
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, fmalita, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.8   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Beth Dakin
Reported 2013-02-01 09:16:05 PST
ScrollAnimatorMac should adopt contentAreaScrolledInDirection. <rdar://problem/12434779>
Attachments
Patch (12.79 KB, patch)
2013-02-01 09:27 PST, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (13.00 KB, patch)
2013-02-01 10:55 PST, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-02-01 09:27:40 PST
Created attachment 186061 [details] Patch
Anders Carlsson
Comment 2 2013-02-01 10:28:03 PST
Comment on attachment 186061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186061&action=review > Source/WebCore/platform/ScrollAnimator.h:97 > + virtual void notifyContentAreaScrolled(const FloatPoint& /*delta*/) { } I don't like the /*delta*/ - why just not name the parameter? Also, shouldn't the delta be a FloatSize? Also, I know that Dan hates using the term delta for this, why not offset?
Beth Dakin
Comment 3 2013-02-01 10:55:08 PST
Created attachment 186079 [details] Patch
Beth Dakin
Comment 4 2013-02-01 11:00:54 PST
Thank you! http://trac.webkit.org/changeset/141610
Florin Malita
Comment 5 2013-02-01 11:48:19 PST
(In reply to comment #4) > Thank you! > > http://trac.webkit.org/changeset/141610 This appears to have busted the Win builds (both CR & Apple): http://build.webkit.org/builders/Chromium%20Win%20Release/builds/53692/steps/compile-webkit/logs/stdio Please take a look.
Beth Dakin
Comment 6 2013-02-01 11:56:33 PST
Committed a speculative fix: http://trac.webkit.org/changeset/141620
Beth Dakin
Comment 7 2013-02-01 12:15:29 PST
Tried again with http://trac.webkit.org/changeset/141625
Note You need to log in before you can comment on or make changes to this bug.