Summary: | ScrollAnimatorMac should adopt contentAreaScrolledInDirection | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
Component: | Layout and Rendering | Assignee: | Beth Dakin <bdakin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, fmalita, sam, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | OS X 10.8 | ||||||||
Attachments: |
|
Description
Beth Dakin
2013-02-01 09:16:05 PST
Created attachment 186061 [details]
Patch
Comment on attachment 186061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186061&action=review > Source/WebCore/platform/ScrollAnimator.h:97 > + virtual void notifyContentAreaScrolled(const FloatPoint& /*delta*/) { } I don't like the /*delta*/ - why just not name the parameter? Also, shouldn't the delta be a FloatSize? Also, I know that Dan hates using the term delta for this, why not offset? Created attachment 186079 [details]
Patch
Thank you! http://trac.webkit.org/changeset/141610 (In reply to comment #4) > Thank you! > > http://trac.webkit.org/changeset/141610 This appears to have busted the Win builds (both CR & Apple): http://build.webkit.org/builders/Chromium%20Win%20Release/builds/53692/steps/compile-webkit/logs/stdio Please take a look. Committed a speculative fix: http://trac.webkit.org/changeset/141620 Tried again with http://trac.webkit.org/changeset/141625 |