Bug 10864

Summary: Linux\GDK build fixes
Product: WebKit Reporter: Krzysztof Kowalczyk <kkowalczyk>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: OS X 10.4   
Attachments:
Description Flags
fix linux\gdk build
aroben: review+
fix the name in ChangeLog and remove tab aroben: review+

Krzysztof Kowalczyk
Reported 2006-09-14 20:43:01 PDT
Attached patch fixes GDK build. The only (I hope) controversial thing is adding #define USE_OLD_CAIRO in FontDataGdk.cpp. If defined, it makes the build compile with older (1.0.4) version of cairo (which seems to be standard on most distros e.g. my Ubuntu 6.06.1) by not using a cairo_scaled_font_text_extents() which is only available in later cairo builds. I think that it's better to have a build working out of the box on popular distros rather than force people to install their own copy of cairo (which is non-trivial for most people).
Attachments
fix linux\gdk build (29.02 KB, patch)
2006-09-14 20:43 PDT, Krzysztof Kowalczyk 		aroben: review+
DetailsFormatted DiffDiff
fix the name in ChangeLog and remove tab (29.03 KB, patch)
2006-09-15 01:28 PDT, Krzysztof Kowalczyk 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Krzysztof Kowalczyk
Comment 1 2006-09-14 20:43:29 PDT
Created attachment 10569 [details] fix linux\gdk build
Adam Roben (:aroben)
Comment 2 2006-09-14 20:56:34 PDT
Comment on attachment 10569 [details] fix linux\gdk build It looks like you've got a tab character in WebCore/Projects/gdk/webcore-gdk.bkl Also, can you remove the commas from the end of your name in the ChangeLog? Other than those, r=me
Krzysztof Kowalczyk
Comment 3 2006-09-15 01:28:09 PDT
Created attachment 10572 [details] fix the name in ChangeLog and remove tab Just like the previous patch with tab in webcore-gdk.bkl removed and the commas after name removed in ChangeLog
Adam Roben (:aroben)
Comment 4 2006-09-15 11:28:33 PDT
Comment on attachment 10572 [details] fix the name in ChangeLog and remove tab r=me
Mark Rowe (bdash)
Comment 5 2006-09-15 17:32:53 PDT
Landed in r16382.
Note You need to log in before you can comment on or make changes to this bug.