Bug 108631

Summary:

[GTK] Include files from DerivedSources/webkitdom for introspection

Product:

WebKit

Reporter:

Tomas Popela <tpopela>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, webkit.review.bot, xan.lopez, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Removed tab character	none

Tomas Popela

Reported 2013-02-01 06:30:13 PST

When compiling webkit with --enable-introspection there are not generated bindings for webkitdom/WebKitDOM* files in WebKit-3.0.gir.

Attachments
Proposed patch (2.19 KB, patch) 2013-02-01 06:55 PST, Tomas Popela	no flags	Details Formatted Diff Diff
Removed tab character (2.20 KB, patch) 2013-02-01 07:09 PST, Tomas Popela	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tomas Popela

Comment 1 2013-02-01 06:55:27 PST

Created attachment 186034 [details] Proposed patch Proposed patch to fix introspection for files in webkitdom

WebKit Review Bot

Comment 2 2013-02-01 06:57:05 PST

Attachment 186034 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit/gtk/GNUmakefile.am', u'Source/WebKit2/GNUmakefile.am']" exit_code: 1 ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tomas Popela

Comment 3 2013-02-01 07:09:21 PST

Created attachment 186036 [details] Removed tab character Removed tab character

WebKit Review Bot

Comment 4 2013-02-08 08:18:40 PST

Comment on attachment 186036 [details] Removed tab character Clearing flags on attachment: 186036 Committed r142285: <http://trac.webkit.org/changeset/142285>

WebKit Review Bot

Comment 5 2013-02-08 08:18:43 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.