Bug 108600

Summary: Web Inspector: [Canvas] do not store a dropped trace log in backend
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Andrey Adaikin
Reported 2013-02-01 01:56:51 PST
Clear memory immediately on dropping current trace log instead of waiting for the next capture command. Patch to follow.
Attachments
Patch (1.92 KB, patch)
2013-02-01 01:58 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2013-02-01 01:58:32 PST
Created attachment 185983 [details] Patch
Pavel Feldman
Comment 2 2013-02-04 00:26:02 PST
Comment on attachment 185983 [details] Patch Missing a test
Andrey Adaikin
Comment 3 2013-02-04 03:25:00 PST
(In reply to comment #2) > (From update of attachment 185983 [details]) > Missing a test hm... this is quite hard to test (injected script), and IMO does not worth testing, in a sense, that the only thing that changed is nulling a pointer upon dropping a trace log.
Pavel Feldman
Comment 4 2013-02-04 03:41:32 PST
Comment on attachment 185983 [details] Patch At this point, I don't think proceeding with no tests at all is acceptable. We need at least some acceptance tests.
WebKit Review Bot
Comment 5 2013-02-05 04:36:12 PST
Comment on attachment 185983 [details] Patch Clearing flags on attachment: 185983 Committed r141884: <http://trac.webkit.org/changeset/141884>
WebKit Review Bot
Comment 6 2013-02-05 04:36:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.