Bug 108593 – PatchLogs are not getting created on QueueStatusServer

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alan Cutter]

As I feared the QueueStatusServer is recording WarningLogs of situations that should not be occuring. It seems the new patch event is not firing properly.


> WarningLog Entities
> ‹ Prev 20 1-20 Next 20 ›
> 	ID/Name	 attachment_id	 bot_id	 date	 event	 message	 queue_name
> 	id=16266401	 185877	 <null>	 2013-01-31 23:15:54.614992	 patchlog missing	 In stopped event.	 qt-ews
> 	id=16293052	 185871	 <null>	 2013-01-31 23:10:18.116004	 patchlog missing	 In started event.	 cr-android-ews
> 	id=16293054	 185876	 <null>	 2013-01-31 23:11:18.841028	 patchlog missing	 In started event.	 mac-wk2-ews
> 	id=16293057	 185820	 <null>	 2013-01-31 23:12:18.544522	 patchlog missing	 In started event.	 mac-ews
> 	id=16293058	 185877	 gce-feeder-01	 2013-01-31 23:12:33.404067	 patchlog missing	 In updated event.	 style-queue
> 	id=16293060	 185874	 gce-feeder-01	 2013-01-31 23:15:20.372430	 patchlog missing	 In updated event.	 style-queue
> 	id=16293063	 185877	 gce-cr-linux-03	 2013-01-31 23:19:14.419893	 patchlog missing	 In updated event.	 chromium-ews
> 	id=16293066	 185817	 webkit-ews-05	 2013-01-31 23:23:00.177826	 patchlog missing	 In updated event.	 mac-ews
> 	id=16293068	 185878	 <null>	 2013-01-31 23:23:29.308874	 patchlog missing	 In started event.	 style-queue
> 	id=16293070	 185878	 gce-feeder-01	 2013-01-31 23:23:41.453208	 patchlog missing	 In updated event.	 style-queue
> 	id=16293071	 185872	 <null>	 2013-01-31 23:25:42.723639	 patchlog missing	 In stopped event.	 cr-linux-debug-ews
> 	id=16293072	 185877	 gce-cr-linux-debug-02	 2013-01-31 23:31:25.011596	 patchlog missing	 In updated event.	 cr-linux-debug-ews
> 	id=16293073	 185881	 gce-feeder-01	 2013-01-31 23:31:50.778616	 patchlog missing	 In updated event.	 style-queue
> 	id=16293077	 185882	 ossy-ews1	 2013-01-31 23:39:20.158627	 patchlog missing	 In updated event.	 qt-ews
> 	id=16293078	 183266	 <null>	 2013-01-31 23:40:44.137799	 patchlog missing	 In stopped event.	 efl-ews
> 	id=16293081	 185874	 <null>	 2013-01-31 23:47:50.745270	 patchlog missing	 In started event.	 cr-android-ews
> 	id=16293082	 185879	 webkit-ews-15	 2013-01-31 23:48:45.718639	 patchlog missing	 In updated event.	 mac-wk2-ews
> 	id=16293087	 185881	 gce-cr-linux-01	 2013-01-31 23:54:06.933829	 patchlog missing	 In updated event.	 chromium-ews
> 	id=16293088	 185831	 <null>	 2013-01-31 23:54:28.178185	 patchlog missing	 In started event.	 mac-ews
> 	id=16293089	 185838	 webkit-ews-01	 2013-01-31 23:55:32.079379	 patchlog missing	 In updated event.	 mac-ews
>  	
> ‹ Prev 20 1-20 Next 20 ›

[Alan Cutter]

Created attachment 185967 [details]
Patch

[WebKit Review Bot]

Comment on attachment 185967 [details]
Patch

Rejecting attachment 185967 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 185967, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
/webkit-commit-queue

Parsed 3 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/QueueStatusServer/app.yaml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Tools/QueueStatusServer/app.yaml.rej
patching file Tools/QueueStatusServer/handlers/submittoews.py

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16358943

[Alan Cutter]

Created attachment 186299 [details]
Patch

[Alan Cutter]

(In reply to comment #3)
> Created an attachment (id=186299) [details]
> Patch

Repatching against tip of tree to avoid conflict.

[WebKit Review Bot]

Comment on attachment 186299 [details]
Patch

Clearing flags on attachment: 186299

Committed r141739: <http://trac.webkit.org/changeset/141739>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.