Bug 108528 – [Efl] Enable spellchecking tests added in r141354

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Rouslan Solomakhin]

http://trac.webkit.org/changeset/141354 added a whole bunch of spellchecking tests. We should enable these on Efl.

[Grzegorz Czajkowski]

Hi,

Unfortunately, these tests can not be enabled for EFL (WK2) as our implementation lack of features required by the tests:
 - smartInsertDeleteEnabled,
 - unified text checker,
 - asynchronous spell checking.

BTW, do those tests really need asynchronous spell checking? It seems they in vast majority test selection/white space matters (please correct me if I am wrong).

One of the added test requires selection to get suggestions for the misspelled word. Linux WebKit ports omit this policy (bug 103520).

[Rouslan Solomakhin]

Perhaps we can do "if (testRunner.smartInsertDeleteEnabled) testRunner.smartInsertDeleteEnabled(true);" ?

[Rouslan Solomakhin]

(In reply to comment #1)
> BTW, do those tests really need asynchronous spell checking? It seems they in vast majority test selection/white space matters (please correct me if I am wrong).

My original goal with the tests was to make Chromium port work better. Chromium uses async spellcheck on all operating systems except Mac. Perhaps we can split the tests into two groups: async and sync?

[Grzegorz Czajkowski]

(In reply to comment #3)
> (In reply to comment #1)
> > BTW, do those tests really need asynchronous spell checking? It seems they in vast majority test selection/white space matters (please correct me if I am wrong).
> 
> My original goal with the tests was to make Chromium port work better. Chromium uses async spellcheck on all operating systems except Mac. Perhaps we can split the tests into two groups: async and sync?

It'd great! As far as I know EFL and GTK+ haven't implemented asynchronous spell checking yet so it prevents to run spelling and editing aspects provided by your tests.

(In reply to comment #2)
> Perhaps we can do "if (testRunner.smartInsertDeleteEnabled) testRunner.smartInsertDeleteEnabled(true);" ?

IMHO that would be more convincing and it's likely to pass the tests which do not require 'smartInsertDelete' feature.

[Rouslan Solomakhin]

Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix, because it's redundant to your bug https://bugs.webkit.org/show_bug.cgi?id=108172 ?

[Grzegorz Czajkowski]

(In reply to comment #5)
> Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix, because it's redundant to your bug https://bugs.webkit.org/show_bug.cgi?id=108172 ?

Hi,
Please don't close this bug. It traces enabling these spell checking tests for EFL. I hope to unskip than as soon as dependency land.

[Rouslan Solomakhin]

Sounds good.

[Grzegorz Czajkowski]

spelling-exactly-selected-word.html and spelling-with-punctuation-selection.html unskipped in r149730.
    
spelling-with-whitespace-selection.html unskipped in r148421.

[Grzegorz Czajkowski]

spelling-double-clicked-word.html unskipped in r150363.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.