Summary: | [Mac] Enable spellchecking tests added in r141471 | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||||||||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, darin, enrica, g.czajkowski, gyuyoung.kim, jiapu.mail, rakuco, rniwa, rouslan+webkit, tony, webkit-bug-importer, webkit-ews | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Bug Depends on: | 108498, 114337 | ||||||||||||||||||||||
Bug Blocks: | 114470 | ||||||||||||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-01-31 14:22:32 PST
Created attachment 185891 [details]
Patch
Comment on attachment 185891 [details] Patch Need to merge this with the change from bug 108509, when it lands. Created attachment 186114 [details]
Patch
Thanks for the patch! Let's see what mac & mac-wk2 EWS have to say. Comment on attachment 186114 [details]
Patch
I don't think we want to enable tests with FAILs in them.
(In reply to comment #5) > (From update of attachment 186114 [details]) > I don't think we want to enable tests with FAILs in them. Oh, I thought for Mac we preferred to check in failing expected results over Skip lines in TestExpectations. I don't have a strong preference of what we should do for failing tests on Mac-- I suggested this to rouslan because I thought this was how we handled Mac failures. Created attachment 186408 [details]
Patch
Comment on attachment 186408 [details]
Patch
Instead of checking in the expected test outputs for failure, I changed [Skip] to [Failure] in TestExpectations for failing spellcheck tests. For passing spellcheck tests, I removed the [Skip] lines in TestExpectations.
Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix? (In reply to comment #9) > Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix? I don't think that makes sense. There's no reason these tests should fail on non-async implementation of spellchecks. Created attachment 197199 [details]
Work in progress
Created attachment 197218 [details]
Work in progress 2
Created attachment 197685 [details]
Fixes, removes, and re-enables tests as needed
Comment on attachment 197685 [details] Fixes, removes, and re-enables tests as needed Attachment 197685 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/106013 Comment on attachment 197685 [details] Fixes, removes, and re-enables tests as needed Attachment 197685 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/105015 Created attachment 197695 [details]
Fixed builds
Comment on attachment 197695 [details] Fixed builds Attachment 197695 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/105051 New failing tests: editing/spelling/spelling-changed-text.html Created attachment 197707 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 197709 [details]
Added a failing expectation on WebKit2
Comment on attachment 197709 [details] Added a failing expectation on WebKit2 Clearing flags on attachment: 197709 Committed r148282: <http://trac.webkit.org/changeset/148282> All reviewed patches have been landed. Closing bug. |