Bug 108525

Summary: [Mac] Enable spellchecking tests added in r141471
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, enrica, g.czajkowski, gyuyoung.kim, jiapu.mail, rakuco, rniwa, rouslan+webkit, tony, webkit-bug-importer, webkit-ews
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 108498, 114337    
Bug Blocks: 114470    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Work in progress
none
Work in progress 2
none
Fixes, removes, and re-enables tests as needed
none
Fixed builds
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Added a failing expectation on WebKit2 none

Description Ryosuke Niwa 2013-01-31 14:22:32 PST
http://trac.webkit.org/changeset/141471 added a whole bunch of spellchecking tests. We should enable these on Mac.
Comment 1 Rouslan Solomakhin 2013-01-31 16:33:15 PST
Created attachment 185891 [details]
Patch
Comment 2 Rouslan Solomakhin 2013-01-31 17:13:31 PST
Comment on attachment 185891 [details]
Patch

Need to merge this with the change from bug 108509, when it lands.
Comment 3 Rouslan Solomakhin 2013-02-01 13:01:10 PST
Created attachment 186114 [details]
Patch
Comment 4 Ryosuke Niwa 2013-02-01 13:02:29 PST
Thanks for the patch! Let's see what mac & mac-wk2 EWS have to say.
Comment 5 Ryosuke Niwa 2013-02-03 14:24:43 PST
Comment on attachment 186114 [details]
Patch

I don't think we want to enable tests with FAILs in them.
Comment 6 Tony Chang 2013-02-04 09:53:32 PST
(In reply to comment #5)
> (From update of attachment 186114 [details])
> I don't think we want to enable tests with FAILs in them.

Oh, I thought for Mac we preferred to check in failing expected results over Skip lines in TestExpectations.

I don't have a strong preference of what we should do for failing tests on Mac-- I suggested this to rouslan because I thought this was how we handled Mac failures.
Comment 7 Rouslan Solomakhin 2013-02-04 10:01:27 PST
Created attachment 186408 [details]
Patch
Comment 8 Rouslan Solomakhin 2013-02-04 10:02:39 PST
Comment on attachment 186408 [details]
Patch

Instead of checking in the expected test outputs for failure, I changed [Skip] to [Failure] in TestExpectations for failing spellcheck tests. For passing spellcheck tests, I removed the [Skip] lines in TestExpectations.
Comment 9 Rouslan Solomakhin 2013-02-22 17:36:50 PST
Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix?
Comment 10 Ryosuke Niwa 2013-02-22 17:39:02 PST
(In reply to comment #9)
> Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix?

I don't think that makes sense. There's no reason these tests should fail on non-async implementation of spellchecks.
Comment 11 Ryosuke Niwa 2013-04-09 20:47:14 PDT
Created attachment 197199 [details]
Work in progress
Comment 12 Ryosuke Niwa 2013-04-10 00:29:27 PDT
Created attachment 197218 [details]
Work in progress 2
Comment 13 Radar WebKit Bug Importer 2013-04-10 02:14:16 PDT
<rdar://problem/13618029>
Comment 14 Ryosuke Niwa 2013-04-11 15:59:08 PDT
Created attachment 197685 [details]
Fixes, removes, and re-enables tests as needed
Comment 15 EFL EWS Bot 2013-04-11 16:08:51 PDT
Comment on attachment 197685 [details]
Fixes, removes, and re-enables tests as needed

Attachment 197685 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/106013
Comment 16 Early Warning System Bot 2013-04-11 16:13:18 PDT
Comment on attachment 197685 [details]
Fixes, removes, and re-enables tests as needed

Attachment 197685 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/105015
Comment 17 Ryosuke Niwa 2013-04-11 16:18:32 PDT
Created attachment 197695 [details]
Fixed builds
Comment 18 Build Bot 2013-04-11 18:31:53 PDT
Comment on attachment 197695 [details]
Fixed builds

Attachment 197695 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/105051

New failing tests:
editing/spelling/spelling-changed-text.html
Comment 19 Build Bot 2013-04-11 18:31:56 PDT
Created attachment 197707 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 20 Ryosuke Niwa 2013-04-11 18:55:48 PDT
Created attachment 197709 [details]
Added a failing expectation on WebKit2
Comment 21 WebKit Commit Bot 2013-04-12 09:51:15 PDT
Comment on attachment 197709 [details]
Added a failing expectation on WebKit2

Clearing flags on attachment: 197709

Committed r148282: <http://trac.webkit.org/changeset/148282>
Comment 22 WebKit Commit Bot 2013-04-12 09:51:20 PDT
All reviewed patches have been landed.  Closing bug.