Bug 108521

Summary:

Setting tests on flakiness dashboard should invalidate builder.

Product:

WebKit

Reporter:

Julie Parent <jparent>

Component:

Tools / Tests

Assignee:

Julie Parent <jparent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Julie Parent 2013-01-31 13:56:54 PST

Setting tests on flakiness dashboard should invalidate builder.

Comment 1 Julie Parent 2013-01-31 13:58:55 PST

Created attachment 185855 [details]
Patch

Comment 2 Julie Parent 2013-01-31 14:00:51 PST

I found this existing bug while testing something else, turns out my last CL makes this fix trivial.

Comment 3 Julie Parent 2013-02-04 16:59:30 PST

Anyone want to take this one? It is a simple one-liner.

When you specify particular tests you are moving into cross-builder mode, so the builder becomes invalid.

Comment 4 Dirk Pranke 2013-02-04 17:00:38 PST

Comment on attachment 185855 [details]
Patch

sorry, thought I had gotten this already.

Comment 5 WebKit Review Bot 2013-02-04 17:31:49 PST

Comment on attachment 185855 [details]
Patch

Clearing flags on attachment: 185855

Committed r141838: <http://trac.webkit.org/changeset/141838>

Comment 6 WebKit Review Bot 2013-02-04 17:31:53 PST

All reviewed patches have been landed.  Closing bug.