Bug 108479

Summary: [Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: PlatformAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, krit, leviw, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Selection inaccuracy with viewbox scaling none

Dominik Röttsches (drott)
Reported 2013-01-31 07:07:46 PST
There's legacy code in FontHarfBuzz.cpp that unnecessarily truncates the argument to an integer, that's not necessary any more since the signature of the called function had been changed a while ago.
Attachments
Patch (2.11 KB, patch)
2013-02-04 06:45 PST, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Selection inaccuracy with viewbox scaling (332 bytes, text/html)
2013-02-04 10:00 PST, Dominik Röttsches (drott) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2013-02-04 06:45:26 PST
Created attachment 186367 [details] Patch
Emil A Eklund
Comment 2 2013-02-04 09:24:49 PST
Is this affecting SVG at all (as per the comment)?
Dominik Röttsches (drott)
Comment 3 2013-02-04 10:00:52 PST
Created attachment 186407 [details] Selection inaccuracy with viewbox scaling (In reply to comment #2) > Is this affecting SVG at all (as per the comment)? I think so - if you look at the attached test case you see that text selection is broken/inaccurate in the first inline svg image which uses 100x viewport scaling. My patch is not the full solution to this issue. I found this while experimenting to find a test case. But it will probably be a necessary step to solve this completely.
WebKit Review Bot
Comment 4 2013-02-04 10:23:01 PST
Comment on attachment 186367 [details] Patch Clearing flags on attachment: 186367 Committed r141778: <http://trac.webkit.org/changeset/141778>
WebKit Review Bot
Comment 5 2013-02-04 10:23:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.