Summary: | [Qt] Properly layer QtWebContext on top of the C API | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jocelyn Turcotte <jturcotte> | ||||||||
Component: | WebKit Qt | Assignee: | Jocelyn Turcotte <jturcotte> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | allan.jensen, benjamin, hausmann, jturcotte | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 109829 | ||||||||||
Bug Blocks: | 108471, 109922, 111435 | ||||||||||
Attachments: |
|
Description
Jocelyn Turcotte
2013-01-31 06:16:45 PST
Created attachment 187826 [details]
Patch
Created attachment 187827 [details]
Patch
Fix a sentence in the ChangeLog
Comment on attachment 187827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187827&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:917 > +void QQuickWebViewPrivate::didReceiveMessageFromNavigatorQtObject(WKStringRef message) > { > QVariantMap variantMap; > - variantMap.insert(QLatin1String("data"), QString(message)); > + variantMap.insert(QLatin1String("data"), WKStringCopyQString(message)); So your message is a WKString but WKStringCopyQString creates a QString? I think the naming of that method is confusing. CopyTo? anywya it that is the common naming then that is fine, I just found it a bit confusing Comment on attachment 187827 [details]
Patch
I'm working on splitting this patch in 2-3.
Created attachment 188348 [details]
Patch
Splitted patch
Comment on attachment 188348 [details]
Patch
After the split-up this patch is indeed pretty simple now. LGTM. I'm hoping Benjamin can sign off on it :)
Sorry, I missed it. Ping me if that happens again. This looks great, I sign off on the change. Committed r145516: <http://trac.webkit.org/changeset/145516> |