Bug 108475 – [Qt] Properly layer QtWebContext on top of the C API

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Jocelyn Turcotte]

QtWebContext, QtWebIconDatabaseClient and QtDownloadManager should be able to simply act as Qt bindings for the corresponding C APIs.

[Jocelyn Turcotte]

Created attachment 187826 [details]
Patch

[Jocelyn Turcotte]

Created attachment 187827 [details]
Patch

Fix a sentence in the ChangeLog

[Kenneth Rohde Christiansen]

Comment on attachment 187827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187827&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:917
> +void QQuickWebViewPrivate::didReceiveMessageFromNavigatorQtObject(WKStringRef message)
>  {
>      QVariantMap variantMap;
> -    variantMap.insert(QLatin1String("data"), QString(message));
> +    variantMap.insert(QLatin1String("data"), WKStringCopyQString(message));

So your message is a WKString but WKStringCopyQString creates a QString? I think the naming of that method is confusing. CopyTo? anywya it that is the common naming then that is fine, I just found it a bit confusing

[Jocelyn Turcotte]

Comment on attachment 187827 [details]
Patch

I'm working on splitting this patch in 2-3.

[Jocelyn Turcotte]

Created attachment 188348 [details]
Patch

Splitted patch

[Simon Hausmann]

Comment on attachment 188348 [details]
Patch

After the split-up this patch is indeed pretty simple now. LGTM. I'm hoping Benjamin can sign off on it :)

[Benjamin Poulain]

Sorry, I missed it. Ping me if that happens again.

This looks great, I sign off on the change.

[Jocelyn Turcotte]

Committed r145516: <http://trac.webkit.org/changeset/145516>