Summary: | [chromium] move ownership of TestRunner object to TestInterfaces | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jochen | ||||||||||||||
Component: | New Bugs | Assignee: | jochen | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 91308 | ||||||||||||||||
Attachments: |
|
Description
jochen
2013-01-31 05:12:54 PST
Created attachment 185755 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Very nice. Created attachment 185834 [details]
Patch for landing
Comment on attachment 185834 [details] Patch for landing Rejecting attachment 185834 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 185834, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: erTree/chromium/TestRunner/src/WebTestRunner.cpp Hunk #1 FAILED at 28. Hunk #2 FAILED at 222. 2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp.rej patching file Tools/DumpRenderTree/chromium/TestShell.cpp patching file Tools/DumpRenderTree/chromium/TestShell.h Hunk #1 succeeded at 108 (offset 1 line). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16251534 Created attachment 185847 [details]
Patch for landing
Comment on attachment 185847 [details] Patch for landing Rejecting attachment 185847 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 185847, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: erTree/chromium/TestRunner/src/WebTestRunner.cpp Hunk #1 FAILED at 28. Hunk #2 FAILED at 222. 2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp.rej patching file Tools/DumpRenderTree/chromium/TestShell.cpp patching file Tools/DumpRenderTree/chromium/TestShell.h Hunk #1 succeeded at 108 (offset 1 line). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16296011 Created attachment 185863 [details]
Patch
Created attachment 185964 [details]
Patch for landing for realz
Comment on attachment 185964 [details] Patch for landing for realz Attachment 185964 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16297597 New failing tests: http/tests/inspector/extensions-headers.html inspector/extensions/extensions-audits-api.html inspector/extensions/extensions-network.html http/tests/inspector/injected-script-for-origin.html inspector/extensions/extensions-audits-content-script.html http/tests/inspector/extensions-network-redirect.html inspector/extensions/extensions-audits.html inspector/extensions/extensions-reload.html inspector/extensions/extensions-console.html inspector/extensions/extensions-sidebar.html inspector/extensions/extensions-resources.html inspector/extensions/extensions-eval-content-script.html inspector/extensions/extensions-eval.html http/tests/inspector/extensions-useragent.html inspector/extensions/extensions-panel.html inspector/extensions/extensions-api.html Created attachment 186027 [details]
Patch
Comment on attachment 186027 [details] Patch Clearing flags on attachment: 186027 Committed r141596: <http://trac.webkit.org/changeset/141596> All reviewed patches have been landed. Closing bug. |