Bug 108464

Summary:

[chromium] move ownership of TestRunner object to TestInterfaces

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

91308

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch	none
Patch for landing for realz	none
Patch	none

jochen

Reported 2013-01-31 05:12:54 PST

[chromium] move ownership of TestRunner object to TestInterfaces

Attachments
Patch (55.11 KB, patch) 2013-01-31 05:14 PST, jochen	no flags	Details Formatted Diff Diff
Patch for landing (28.50 KB, patch) 2013-01-31 12:07 PST, jochen	no flags	Details Formatted Diff Diff
Patch for landing (28.47 KB, patch) 2013-01-31 13:23 PST, jochen	no flags	Details Formatted Diff Diff
Patch (56.90 KB, patch) 2013-01-31 14:20 PST, jochen	no flags	Details Formatted Diff Diff
Patch for landing for realz (57.26 KB, patch) 2013-02-01 00:20 PST, jochen	no flags	Details Formatted Diff Diff
Patch (58.49 KB, patch) 2013-02-01 06:01 PST, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2013-01-31 05:14:19 PST

Created attachment 185755 [details] Patch

WebKit Review Bot

Comment 2 2013-01-31 05:21:11 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Adam Barth

Comment 3 2013-01-31 10:42:37 PST

Very nice.

jochen

Comment 4 2013-01-31 12:07:56 PST

Created attachment 185834 [details] Patch for landing

WebKit Review Bot

Comment 5 2013-01-31 13:01:52 PST

Comment on attachment 185834 [details] Patch for landing Rejecting attachment 185834 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 185834, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: erTree/chromium/TestRunner/src/WebTestRunner.cpp Hunk #1 FAILED at 28. Hunk #2 FAILED at 222. 2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp.rej patching file Tools/DumpRenderTree/chromium/TestShell.cpp patching file Tools/DumpRenderTree/chromium/TestShell.h Hunk #1 succeeded at 108 (offset 1 line). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16251534

jochen

Comment 6 2013-01-31 13:23:08 PST

Created attachment 185847 [details] Patch for landing

WebKit Review Bot

Comment 7 2013-01-31 13:53:12 PST

Comment on attachment 185847 [details] Patch for landing Rejecting attachment 185847 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 185847, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: erTree/chromium/TestRunner/src/WebTestRunner.cpp Hunk #1 FAILED at 28. Hunk #2 FAILED at 222. 2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp.rej patching file Tools/DumpRenderTree/chromium/TestShell.cpp patching file Tools/DumpRenderTree/chromium/TestShell.h Hunk #1 succeeded at 108 (offset 1 line). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16296011

jochen

Comment 8 2013-01-31 14:20:04 PST

Created attachment 185863 [details] Patch

jochen

Comment 9 2013-02-01 00:20:51 PST

Created attachment 185964 [details] Patch for landing for realz

WebKit Review Bot

Comment 10 2013-02-01 02:53:32 PST

Comment on attachment 185964 [details] Patch for landing for realz Attachment 185964 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16297597 New failing tests: http/tests/inspector/extensions-headers.html inspector/extensions/extensions-audits-api.html inspector/extensions/extensions-network.html http/tests/inspector/injected-script-for-origin.html inspector/extensions/extensions-audits-content-script.html http/tests/inspector/extensions-network-redirect.html inspector/extensions/extensions-audits.html inspector/extensions/extensions-reload.html inspector/extensions/extensions-console.html inspector/extensions/extensions-sidebar.html inspector/extensions/extensions-resources.html inspector/extensions/extensions-eval-content-script.html inspector/extensions/extensions-eval.html http/tests/inspector/extensions-useragent.html inspector/extensions/extensions-panel.html inspector/extensions/extensions-api.html

jochen

Comment 11 2013-02-01 06:01:24 PST

Created attachment 186027 [details] Patch

WebKit Review Bot

Comment 12 2013-02-01 08:03:41 PST

Comment on attachment 186027 [details] Patch Clearing flags on attachment: 186027 Committed r141596: <http://trac.webkit.org/changeset/141596>

WebKit Review Bot

Comment 13 2013-02-01 08:03:46 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.