Bug 108457

Summary: [EFL] Disable Web Intents
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, ap, benjamin, dbates, gyuyoung.kim, kenneth, kihong.kwon, lucas.de.marchi, rakuco, simon.fraser, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-01-31 04:15:47 PST
The Web Intents spec seems to be pretty much dead and Google is planning to remove support for it from WebKit soon (See mailing list announcement). We should therefore disable Web Intents in EFL port and remove the corresponding code.
Attachments
Patch (90.91 KB, patch)
2013-01-31 05:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (91.09 KB, patch)
2013-01-31 05:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2013-01-31 04:38:25 PST
I totally agree
Gyuyoung Kim
Comment 2 2013-01-31 04:44:25 PST
AFAIK, Tizen WebKit also disable it because of same reason. CC'ing Kihong.
Chris Dumez
Comment 3 2013-01-31 05:44:17 PST
(In reply to comment #2) > AFAIK, Tizen WebKit also disable it because of same reason. CC'ing Kihong. Yes, it was never enabled for Tizen AFAIK.
Chris Dumez
Comment 4 2013-01-31 05:49:20 PST
Created attachment 185764 [details] Patch
Kenneth Rohde Christiansen
Comment 5 2013-01-31 05:51:17 PST
Comment on attachment 185764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185764&action=review Nice > Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:911 > - DumpRenderTreeSupportEfl::deliverWebIntent(browser->mainFrame(), action, type, data); > + notImplemented(); maybe add a comment that it is not intended to be implemented?
Chris Dumez
Comment 6 2013-01-31 05:54:54 PST
Created attachment 185766 [details] Patch Take Kenneth's comments into consideration.
Alexey Proskuryakov
Comment 7 2013-01-31 10:07:43 PST
Comment on attachment 185766 [details] Patch rs=me
WebKit Review Bot
Comment 8 2013-01-31 10:45:16 PST
Comment on attachment 185766 [details] Patch Clearing flags on attachment: 185766 Committed r141439: <http://trac.webkit.org/changeset/141439>
WebKit Review Bot
Comment 9 2013-01-31 10:45:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.