Summary: | [EFL][WK2] Reenable ewk_auth_request API tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, apavlov, benjamin, gyuyoung.kim, kenneth, kling, laszlo.gombos, lucas.de.marchi, rakuco, sam, tmpsantos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2013-01-31 03:04:09 PST
Created attachment 185733 [details]
Patch
Could I please get informal review for this one? Comment on attachment 185733 [details]
Patch
LGTM. Thanks for fixing/re-enabling it.
Looks good to me as well. Comment on attachment 185733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185733&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:40 > static const char TEST_USERNAME[] = "username"; > static const char TEST_PASSWORD[] = "password"; > +static const char EXPECTED_SUCCESS_TITLE[] = "EFLWebKit2 Authentication test"; > static const char EXPECTED_AUTHORIZATION[] = "Basic dXNlcm5hbWU6cGFzc3dvcmQ="; // Base64 encoding of "username:password". > static const char INDEX_HTML_STRING[] = This style is a bit far from WebKit style. Created attachment 187928 [details]
Patch for landing
Fixed the naming of the static variables to follow WebKit coding style.
Comment on attachment 187928 [details] Patch for landing Clearing flags on attachment: 187928 Committed r142678: <http://trac.webkit.org/changeset/142678> All reviewed patches have been landed. Closing bug. |