Bug 108441

Summary: [V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, d-r, fmalita, japhet, jberlin, ojan.autocc, pdr, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Kentaro Hara
Reported 2013-01-31 00:41:59 PST
A complicated condition in GetInternalFields() can be simplified by using InheritsExtendedAttribute("EventTarget").
Attachments
Patch (3.45 KB, patch)
2013-01-31 00:43 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (4.22 KB, patch)
2013-02-03 18:23 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-31 00:43:34 PST
Created attachment 185708 [details] Patch
Adam Barth
Comment 2 2013-01-31 10:19:45 PST
Comment on attachment 185708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185708&action=review > Source/WebCore/svg/SVGElementInstance.idl:32 > + EventTarget Won't SVGElementInstance get "InheritsExtendedAttribute" by deriving from EventTarget?
Kentaro Hara
Comment 3 2013-01-31 15:47:41 PST
Comment on attachment 185708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185708&action=review >> Source/WebCore/svg/SVGElementInstance.idl:32 >> + EventTarget > > Won't SVGElementInstance get "InheritsExtendedAttribute" by deriving from EventTarget? 'SVGElementInstance : EventTarget' is enabled only in ObjC. Similarly, 'Node : EventTarget' is enabled only in ObjC. (Enabling the inheritance causes a bunch of side effects on CodeGenerator{JS,V8}.pm, so I'll study it later.)
WebKit Review Bot
Comment 4 2013-01-31 16:27:16 PST
Comment on attachment 185708 [details] Patch Clearing flags on attachment: 185708 Committed r141502: <http://trac.webkit.org/changeset/141502>
WebKit Review Bot
Comment 5 2013-01-31 16:27:20 PST
All reviewed patches have been landed. Closing bug.
Jessie Berlin
Comment 6 2013-01-31 17:58:40 PST
Kentaro Hara is going to roll out the patch because it started causing assertion failures in some svg tests on the apple mac bots: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r141504%20(7008)/results.html VM Regions Near 0xbbadbeef: --> __TEXT 0000000102daa000-0000000102dab000 [ 4K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit2.framework/WebProcess.app/Contents/MacOS/WebProcess Application Specific Information: objc[5765]: garbage collection is OFF CRASHING TEST: svg/custom/use-on-use.svg Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000106ae9da2 WebCore::SVGElementInstance::eventTargetData() + 66 (SVGElementInstance.cpp:191) 1 com.apple.WebCore 0x0000000105d881e6 WebCore::EventTarget::hasEventListeners() + 22 (EventTarget.h:197) 2 com.apple.WebCore 0x0000000105f1d82c _ZN7WebCoreL12isObservableEPNS_13JSEventTargetE + 60 (JSEventTarget.cpp:161)
Kentaro Hara
Comment 7 2013-01-31 17:59:11 PST
Reverted r141502 for reason: Hit assert in SVGElementInstance Committed r141518: <http://trac.webkit.org/changeset/141518>
Kentaro Hara
Comment 8 2013-02-03 18:23:53 PST
Created attachment 186285 [details] patch for landing
WebKit Review Bot
Comment 9 2013-02-03 19:24:19 PST
Comment on attachment 186285 [details] patch for landing Clearing flags on attachment: 186285 Committed r141730: <http://trac.webkit.org/changeset/141730>
WebKit Review Bot
Comment 10 2013-02-03 19:24:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.