Bug 108429

Summary: Inner SVG elements can disable child repaints
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, d-r, eric, fmalita, gyuyoung.kim, krit, ojan.autocc, rakuco, rniwa, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Prevent skipped repaints for children of inner SVG elements
eric: review+, webkit.review.bot: commit-queue-
Update for landing none

Philip Rogers
Reported 2013-01-30 22:30:25 PST
We* introduced a nasty painting regression with the following: r108699 contained a bug where "m_didTransformToRoot" is never unset for viewport containers such as inner <svg> elements. r133786 used "m_didTransformToRoot" to skip child repaints. As a result, inner SVG elements can prevent repaints for children. Patch forthcoming. * where "we" is "me" :( Downstream bug: https://code.google.com/p/chromium/issues/detail?id=172680
Attachments
Prevent skipped repaints for children of inner SVG elements (13.50 KB, patch)
2013-01-30 23:38 PST, Philip Rogers 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Update for landing (13.66 KB, patch)
2013-02-01 12:30 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2013-01-30 23:38:37 PST
Created attachment 185686 [details] Prevent skipped repaints for children of inner SVG elements
Eric Seidel (no email)
Comment 2 2013-01-30 23:48:40 PST
Comment on attachment 185686 [details] Prevent skipped repaints for children of inner SVG elements LGTM.
WebKit Review Bot
Comment 3 2013-01-31 00:22:15 PST
Comment on attachment 185686 [details] Prevent skipped repaints for children of inner SVG elements Attachment 185686 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16266045 New failing tests: svg/repaint/svgsvgelement-repaint-children.html
Build Bot
Comment 4 2013-02-01 06:21:16 PST
Comment on attachment 185686 [details] Prevent skipped repaints for children of inner SVG elements Attachment 185686 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16308024
Philip Rogers
Comment 5 2013-02-01 12:30:51 PST
Created attachment 186104 [details] Update for landing
WebKit Review Bot
Comment 6 2013-02-01 14:40:24 PST
Comment on attachment 186104 [details] Update for landing Clearing flags on attachment: 186104 Committed r141645: <http://trac.webkit.org/changeset/141645>
WebKit Review Bot
Comment 7 2013-02-01 14:40:29 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 8 2013-03-20 17:09:40 PDT
Mac rebaseline done in http://trac.webkit.org/changeset/146415.
Note You need to log in before you can comment on or make changes to this bug.