Bug 10840 – REGRESSION: Shadow of file upload button is clipped

• Component: Forms
• Status: RESOLVED FIXED

The shadow below the new file upload button is clipped. See URL and attached screenshot.

Created attachment 10531 [details]
Screenshot

[Adam Roben (:aroben)]

Looks like we just need a little vertical padding to fix this. RenderFileUploadControl pushes a clip in paint() based on the size of the renderer, so we just need to increase the height to keep from clipping the shadow.

[David Kilzer (:ddkilzer)]

Do we need a 'NativeFileUpload' keyword in Bugzilla?

[Adam Roben (:aroben)]

(In reply to comment #3)
> Do we need a 'NativeFileUpload' keyword in Bugzilla?

Adele just created one, and I've added it to the relevant bugs

[Adam Roben (:aroben)]

Created attachment 10560 [details]
Fix: Expand the clip 2px in height

This can be fixed by adding 2px to the height of the clip to allow the shadow to draw. See patch.

P.S. There's something oddly satisfying about using the new upload control to upload a patch to fix the new upload control.

(In reply to comment #5)
> Created an attachment (id=10560) [edit]
> Fix: Expand the clip 2px in height
> 
> This can be fixed by adding 2px to the height of the clip to allow the shadow
> to draw. See patch.
> 

Hmm... this works well for the default style on the Mac (in which case you might as well not clip), but in other cases, i.e. when the button is style (for example, by increasing the font size, which selects a bigger Mac button with bigger shadow, or by using a non-themed button) or set a smaller height for the upload control, it seems to me that this patch will defeat the purpose of clipping, and might also not repaint those 2 pixels (in fact, that's true for the default case too, but it's currently common to all Mac buttons).

[Anders Carlsson]

Committed revision 17555.