Bug 108390 – Make JSEventListener more robust in the event of the compiled handler being released.

• Component: New Bugs
• Status: RESOLVED FIXED

[Oliver Hunt]

Make JSEventListener more robust in the event of the compiled handler being released.

[Oliver Hunt]

Created attachment 185591 [details]
Patch

[Oliver Hunt]

Committed r141348: <http://trac.webkit.org/changeset/141348>

[Geoffrey Garen]

Comment on attachment 185591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185591&action=review

> Source/WebCore/bindings/js/JSLazyEventListener.cpp:-125
> -    // Since we only parse once, there's no need to keep data used for parsing around anymore.
> -    m_functionName = String();
> -    m_code = String();
> -    m_eventParameterName = String();
> -    m_sourceURL = String();

Why do we need this, given the early return?

[Oliver Hunt]

(In reply to comment #3)
> (From update of attachment 185591 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185591&action=review
> 
> > Source/WebCore/bindings/js/JSLazyEventListener.cpp:-125
> > -    // Since we only parse once, there's no need to keep data used for parsing around anymore.
> > -    m_functionName = String();
> > -    m_code = String();
> > -    m_eventParameterName = String();
> > -    m_sourceURL = String();
> 
> Why do we need this, given the early return?

So that we maintain correct behaviour - the only reason we hit this is if we want to execute the function so not running the function would result in incorrect behaviour.